Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of validateUrl - logic for it #10

Open
rufuspollock opened this issue Jan 21, 2016 · 2 comments
Open

Removal of validateUrl - logic for it #10

rufuspollock opened this issue Jan 21, 2016 · 2 comments

Comments

@rufuspollock
Copy link
Contributor

@pwalsh why did we remove validateUrl?

I ask as it lead to breakage upstream in data.okfn.org - not the end of the world - but just wondered on motivation :-)

@pwalsh
Copy link
Contributor

pwalsh commented Jan 21, 2016

It happened in here: #6

We will look at this lib again really soon, and see what we do there.

I should have ensured proper semantic versioning for this API breakage. We also should pin the deps in data.okfn.org

@rufuspollock
Copy link
Contributor Author

I pinned deps now ;-) - just wondering if it was accidental or intentional to remove it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants