From a515611d26613119a9028d7c536a97159577c1d6 Mon Sep 17 00:00:00 2001 From: Pramod Maurya Date: Wed, 6 Nov 2024 15:15:45 +0530 Subject: [PATCH 1/3] added required approvals workflow --- .github/workflows/required_approvals.yml | 26 ++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 .github/workflows/required_approvals.yml diff --git a/.github/workflows/required_approvals.yml b/.github/workflows/required_approvals.yml new file mode 100644 index 00000000000..49645db5543 --- /dev/null +++ b/.github/workflows/required_approvals.yml @@ -0,0 +1,26 @@ +name: PR Approval Workflow +on: + pull_request: + branches: + - main + pull_request_review: + types: [submitted] + +jobs: + check-approvals: + runs-on: ubuntu-latest + permissions: + id-token: write + contents: read + pull-requests: read + steps: + - name: Check for required approvals + id: check-approvals + uses: skymoore/required-approvals@main + with: + token: ${{ secrets.GITHUB_TOKEN }} + read_org_scoped_token: ${{ secrets.READ_ORG_SCOPED_TOKEN }} + org_name: openconfig + min_approvals: 2 + approval_mode: ALL + From 354afa43dc7bb478d4b13c137fb2fd08b3681e1e Mon Sep 17 00:00:00 2001 From: Pramod Maurya Date: Thu, 7 Nov 2024 16:09:22 +0530 Subject: [PATCH 2/3] added comment --- .github/workflows/required_approvals.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/required_approvals.yml b/.github/workflows/required_approvals.yml index 49645db5543..3620513751b 100644 --- a/.github/workflows/required_approvals.yml +++ b/.github/workflows/required_approvals.yml @@ -1,3 +1,4 @@ +# This workflow is to make sure we have 1 LGTM for business logic and 1 LGTM for code style name: PR Approval Workflow on: pull_request: From e1dc2c9cdd9f5a821af544c2f2c1c2ef932c5114 Mon Sep 17 00:00:00 2001 From: Pramod Maurya Date: Wed, 11 Dec 2024 11:33:12 +0530 Subject: [PATCH 3/3] apple --- .github/CODEOWNERS | 2 +- .../otg_tests/link_bandwidth_test/link_bandwidth_test.go | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 2dfea7d093a..22ff7e0ae37 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -13,7 +13,7 @@ # /feature folders each have owners who are auto requested for review and may merge PR's /feature/acl/ @alokmtri-g /feature/aft/ @sudhinj @yunjie-lu -/feature/bgp/ @dplore +/feature/bgp/ @dplore @rohit-rp /feature/dhcp/ @alokmtri-g /feature/ethernet/ @ram-mac /feature/gribi/ @nflath @nachikethas @xw-g diff --git a/feature/bgp/policybase/otg_tests/link_bandwidth_test/link_bandwidth_test.go b/feature/bgp/policybase/otg_tests/link_bandwidth_test/link_bandwidth_test.go index a1205cfa0c0..6293d62aa07 100644 --- a/feature/bgp/policybase/otg_tests/link_bandwidth_test/link_bandwidth_test.go +++ b/feature/bgp/policybase/otg_tests/link_bandwidth_test/link_bandwidth_test.go @@ -37,6 +37,7 @@ import ( ) const ( + apple = "apple" ipv4PrefixLen = 30 ipv6PrefixLen = 126 v41Route = "203.0.113.0"