Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injector and Extractor being different interfaces #479

Closed
carlosalberto opened this issue Feb 19, 2020 · 3 comments
Closed

Injector and Extractor being different interfaces #479

carlosalberto opened this issue Feb 19, 2020 · 3 comments
Assignees
Milestone

Comments

@carlosalberto
Copy link
Contributor

Currently a Propagator is expected to contain inject and extract operations, but OTEP 66 originally exposed different interfaces for them (namely Injector and Extractor), and some languages might be better offering as different interfaces as well.

Probably we can split them in the Specification, while mentioning that implementors can keep them in a unified interface (like most languages do at this moment) if that suits them.

@carlosalberto carlosalberto added this to the v0.4 milestone Feb 19, 2020
@mwear
Copy link
Member

mwear commented Apr 7, 2020

@carlosalberto I can take this, as I think Ruby was one of the hold outs. We've introduced the propagator and composite propagator interfaces, but we build them from individual injectors and extractors. With some minor spec changes we can account for this variation.

@carlosalberto carlosalberto assigned mwear and unassigned carlosalberto Apr 7, 2020
@carlosalberto
Copy link
Contributor Author

@mwear Thanks a lot, appreciated!

@carlosalberto
Copy link
Contributor Author

Closing this via #578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants