Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should a gauge overflow data point be aggregated? #3614

Closed
MrAlias opened this issue Jul 20, 2023 · 2 comments
Closed

How should a gauge overflow data point be aggregated? #3614

MrAlias opened this issue Jul 20, 2023 · 2 comments
Assignees
Labels
question Question for discussion spec:metrics Related to the specification/metrics directory

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Jul 20, 2023

Currently the specification defines an over-flow attribute to be associated with "a synthetic aggregation of the metric events that could not be independently aggregated because of the [cardinality] limit." How should this aggregation behave for gauges? Should it just hold the last-value of all attributes that fall into it? Should it sum the values?

The original intent of the over-flow data point was to communicate a limit had been reached but still provide a way for totals (and rates) to still be calculated. If that is the case it would seen the gauge aggregation should sum all values for this attribute, right?

@MrAlias MrAlias added question Question for discussion spec:metrics Related to the specification/metrics directory labels Jul 20, 2023
@MrAlias MrAlias changed the title How should a gauge overflow data point be aggregated How should a gauge overflow data point be aggregated? Jul 20, 2023
@jack-berg
Copy link
Member

Should it just hold the last-value of all attributes that fall into it?

^^ This. It would be odd to change the aggregation semantics just because an overflow took place. We assert that you should use an up down counter if its semantically meaningful to sum across the dimensions. If a user were to complain that they think the last value aggregation overflow behavior should be to sum, we should instruct them to use an up down counter instead.

@MrAlias MrAlias closed this as completed Jul 27, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Go: Metric SDK (Post-GA) Jul 27, 2023
@jmacd
Copy link
Contributor

jmacd commented Sep 11, 2023

I suspect there will be a future where we can aggregate Gauge overflow into GaugeHistogram.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Question for discussion spec:metrics Related to the specification/metrics directory
Projects
Development

No branches or pull requests

4 participants