Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLP exporter concurrent sending requirements #1405

Open
aabmass opened this issue Feb 5, 2021 · 1 comment
Open

OTLP exporter concurrent sending requirements #1405

aabmass opened this issue Feb 5, 2021 · 1 comment
Labels
area:data-model For issues related to data model area:sdk Related to the SDK release:after-ga Not required before GA release, and not going to work on before GA spec:metrics Related to the specification/metrics directory spec:protocol Related to the specification/protocol directory spec:trace Related to the specification/trace directory

Comments

@aabmass
Copy link
Member

aabmass commented Feb 5, 2021

What are you trying to achieve?
Implementing OTLP exporter concurrent sending in the python SDK (open-telemetry/opentelemetry-python#1108), as required in the spec matrix. Relevant part of specification: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/otlp.md#otlpgrpc-concurrent-requests

What did you expect to see?
Implementation details may be underspecified.

Additional context.
Can we mark this optional in the spec matrix? Is it required for 1.0?

@aabmass aabmass added the spec:protocol Related to the specification/protocol directory label Feb 5, 2021
@carlosalberto carlosalberto added area:sdk Related to the SDK release:after-ga Not required before GA release, and not going to work on before GA spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory labels Feb 8, 2021
@jmacd jmacd added the area:data-model For issues related to data model label Feb 24, 2021
@jmacd
Copy link
Contributor

jmacd commented Feb 24, 2021

The metrics data model should, I believe, explicitly state that OTLP data points may be written out of order. Without such a statement, OTLP exporters will have to be more complicated. As noted in this draft about the metrics data model, https://docs.google.com/document/d/1rncVUp_nzAhA39trS1hUFinIlO01jf7KBbuIRhqMI7Y/edit#, there will come a point where OTLP data is translated into PRW, for example, at which point data will have to have be ordered. This will be one of the challenges for that exporter inside the collector, but it's not a problem for the SDK itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:data-model For issues related to data model area:sdk Related to the SDK release:after-ga Not required before GA release, and not going to work on before GA spec:metrics Related to the specification/metrics directory spec:protocol Related to the specification/protocol directory spec:trace Related to the specification/trace directory
Projects
None yet
Development

No branches or pull requests

3 participants