Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider TraceId/SpanId to implement Stringer interface? #577

Closed
bogdandrutu opened this issue Mar 20, 2020 · 7 comments
Closed

Consider TraceId/SpanId to implement Stringer interface? #577

bogdandrutu opened this issue Mar 20, 2020 · 7 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@bogdandrutu
Copy link
Member

Currently we use SpanIdString() https://github.com/open-telemetry/opentelemetry-go/blob/master/api/core/span_context.go#L174, but if we rename that to just String fmt will print that nicer :)

@rghetia
Copy link
Contributor

rghetia commented Mar 26, 2020

Make sure that structure for print is inline with logging efforts.

@rghetia rghetia added the good first issue Good for newcomers label Mar 26, 2020
@MrAlias
Copy link
Contributor

MrAlias commented Mar 26, 2020

From our SIG meeting: the ask is to possibly add a separate method String instead of replacing this method. The point being that this method might produce the string in a protocol format.

Ideally the String method will conform to the function @rghetia describes.

@oncilla
Copy link
Contributor

oncilla commented Apr 2, 2020

@rghetia can you point me to what the logging efforts are?

@rghetia
Copy link
Contributor

rghetia commented Apr 2, 2020

@rghetia can you point me to what the logging efforts are?

Log SIG recently started and is looking into supporting logs in OpenTelemetry. This doc has some relevant links.

@shouri007
Copy link
Contributor

@MrAlias I'd like to take this up.

@MrAlias
Copy link
Contributor

MrAlias commented Apr 15, 2020

All yours @shouri007 😄

@shouri007
Copy link
Contributor

@MrAlias Can we close this issue as it's resolved now?

@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants