Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus exporter should use stateful batcher #426

Closed
Aneurysm9 opened this issue Jan 10, 2020 · 4 comments
Closed

Prometheus exporter should use stateful batcher #426

Aneurysm9 opened this issue Jan 10, 2020 · 4 comments
Labels
area:metrics Part of OpenTelemetry Metrics bug Something isn't working
Milestone

Comments

@Aneurysm9
Copy link
Member

While attempting to configure a Prometheus exporter I discovered that counter metrics were not behaving as expected, their values would fluctuate up and down and the metrics would disappear from the scrape endpoint when the system was not active. I believe this is because prometheus.NewExportPipeline() missed the change to a stateful batcher from #385 when merge conflicts were resolved in #395.

@paivagustavo
Copy link
Member

Thanks for reporting this right @Aneurysm9. You're right, the batcher should be stateful things must be messed with these merges :)

I've filled #428 to fix that. Once that is merged, could you check if this fixes the problem you're reporting? Otherwise we may need some more information to debug it.

@paivagustavo paivagustavo added bug Something isn't working exporters area:metrics Part of OpenTelemetry Metrics labels Jan 11, 2020
@lizthegrey
Copy link
Member

Addressed in v0.2.1.1

@lizthegrey lizthegrey added this to the Alpha v0.2 milestone Jan 13, 2020
@Aneurysm9
Copy link
Member Author

@paivagustavo thanks for the quick fix. I can confirm that the exporter is now exhibiting the expected behavior.

@paivagustavo
Copy link
Member

Happy that it was fixed, thank you for getting back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants