Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simplified constructor for simple metric SDK setup: prometheus exporter #345

Closed
jmacd opened this issue Nov 22, 2019 · 4 comments
Closed

Add simplified constructor for simple metric SDK setup: prometheus exporter #345

jmacd opened this issue Nov 22, 2019 · 4 comments
Labels
area:metrics Part of OpenTelemetry Metrics good first issue Good for newcomers
Milestone
untracked

Comments

@jmacd
Copy link
Contributor

jmacd commented Nov 22, 2019

Ensure that the Prometheus exporter has a simple method for installing the SDK. This exporter will have to integrate a controller and depends on the defaultkeys batcher, so it should be fairly straightforward.
@jmacd jmacd mentioned this issue Nov 25, 2019
Merged
@rghetia rghetia added the good first issue Good for newcomers label Dec 5, 2019
@VineethReddy02
Copy link
Contributor

I can take this up. Can I know what exactly needs to be done here?

@jmacd
Copy link
Contributor Author

jmacd commented Dec 9, 2019

This issue is similar to but different than #343 and #344 -- I forgot to put the link to #343 which has an explanation. I am concerned that the Prometheus exporter, which is being refactored under #370, may change enough that this work should be postponed until that issue is addressed.

@jmacd jmacd added the hold label Dec 9, 2019
@jmacd
Copy link
Contributor Author

jmacd commented Dec 9, 2019

@paivagustavo Note.

@jmacd jmacd added the area:metrics Part of OpenTelemetry Metrics label Dec 12, 2019
@jmacd jmacd mentioned this issue Dec 18, 2019
Merged
@jmacd
Copy link
Contributor Author

jmacd commented Jan 9, 2020

This was done.

@jmacd jmacd closed this as completed Jan 9, 2020
@jmacd jmacd mentioned this issue Jan 10, 2020
Closed
@jmacd jmacd mentioned this issue Mar 5, 2020
Closed
hstan referenced this issue in hstan/opentelemetry-go Oct 15, 2020
@evantorrie
Add Skip Changelog label to dependabot-sourced PRs. (#345)
d4a624b 
The same was done in open-telemetry#1161
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics good first issue Good for newcomers
Projects
None yet
Milestone
untracked
Development

No branches or pull requests
4 participants
@jmacd @pellared @rghetia @VineethReddy02