Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: WithAttributes should append instead of replacing attributes #309

Closed
iredelmeier opened this issue Nov 11, 2019 · 3 comments · Fixed by #315
Closed

Bug: WithAttributes should append instead of replacing attributes #309

iredelmeier opened this issue Nov 11, 2019 · 3 comments · Fixed by #315
Milestone
untracked

Comments

@iredelmeier
Copy link
Member

This would be especially useful for plugin customization.
@iredelmeier iredelmeier mentioned this issue Nov 11, 2019
Closed
@jmacd
Copy link
Contributor

jmacd commented Nov 11, 2019

I'd call it a bug that WithAttributes does not append.

@iredelmeier
Copy link
Member Author

@jmacd I could get behind that characterization ;)

@iredelmeier iredelmeier changed the title Suggestion: WithAttributes should append instead of replacing attributes Bug: WithAttributes should append instead of replacing attributes Nov 11, 2019
@iredelmeier
Copy link
Member Author

(Also, this is a good-first-issue)

@paivagustavo paivagustavo mentioned this issue Nov 14, 2019
Merged
hstan referenced this issue in hstan/opentelemetry-go Oct 15, 2020
@dependabot @MrAlias
Bump cloud.google.com/go from 0.64.0 to 0.65.0 in /detectors/gcp (#309)
f598244 
* Bump cloud.google.com/go from 0.64.0 to 0.65.0 in /detectors/gcp

Bumps [cloud.google.com/go](https://github.com/googleapis/google-cloud-go) from 0.64.0 to 0.65.0.
- [Release notes](https://github.com/googleapis/google-cloud-go/releases)
- [Changelog](https://github.com/googleapis/google-cloud-go/blob/master/CHANGES.md)
- [Commits](googleapis/google-cloud-go@v0.64.0...v0.65.0)

Signed-off-by: dependabot[bot] <[email protected]>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <[email protected]>
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

change trace.WithAttributes to append values instead of replacing
3 participants
@iredelmeier @jmacd @pellared