-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce multi-arch/platform images and improve build times. #458
Comments
|
If possible it'd be nice to have this by the 1.0 release on friday but nbd if you don't have the bandwidth |
Reopening this -- after merging this in, release builds fail. |
@JaredTan95 could you take another look today? |
https://github.com/open-telemetry/opentelemetry-demo/actions/runs/3286470674/jobs/5414695123 is a link to a failed run |
I noticed a revert PR #502, I found the failure issue and I will reopen PR after fixed it. |
Updates to this issue for posterity:
You can see a successful build here: https://github.com/open-telemetry/opentelemetry-demo/actions/runs/3313405848 However, instead of reducing build time, we've dramatically increased it. There's a few reasons for this:
In an attempt to work around this, I've discarded several solutions:
My current train of thought is to see if it's possible to simply throw more resources at the problem. I've opened open-telemetry/community#1281 to request larger runner support added to the organization. I suspect that if we could 2x or 3x our runner size, these problems would be mitigated. There is one other solution I have in mind, and it's to remove gRPC from the areas where it's causing problems. Payment, Quote, and Shipping are the three big problem areas it seems (especially quote), so if we can remove bloat there then it probably would help. Similarly, it may be worthwhile to go through and normalize gRPC libraries and update them, it seems like there's a lot of outdated stuff and newer versions may be more performant/compact. |
What's the current state here @austinlparker ? I think the current build is just x86 right? Our performance is much better now |
I think this has been solved in #536. Closing for now |
Are you sure @cartersocha Demo Docker images seems only amd64 : https://hub.docker.com/r/otel/demo/tags |
next tag will release multi-arch images. |
Actually we had to remove multi-arch because it takes 4 hours to build. We're working on alternatives still to reduce build time and make this feasible. |
The 1.3.1 release is multi-arch |
To address #396
The text was updated successfully, but these errors were encountered: