-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker HEALTHCHECK to all services using the grpc_health_probe
executable
#93
Conversation
The PR looks fine, I'd just check out the discussion going on at #89 to decide if the |
grpc_health_probe
change to the paymentservice
grpc_health_probe
executable
health to healthy typo Co-authored-by: Cijo Thomas <[email protected]>
Converting to draft while I rework this to not include the binary and instead have instructions for users to download the probe to the correct folder and also add a step to the CIs to download the executable. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Fixes #89
Error building the docker project
Changes
To be done