Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker HEALTHCHECK to all services using the grpc_health_probe executable #93

Closed
wants to merge 22 commits into from

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Jun 2, 2022

Fixes #89

Error building the docker project
image

Changes

  • Includes the gRPC health checking binary to the repository
  • Each service will now copy and use this binary as part of the Docker HEALTHCHECK
  • Adds instructions to inspect health of services correctly showing the change works and shows healthy and unhealthy services

To be done

  • Test and add healtchecking endpoint to all services (not all services currently implement this or not correctly)

@mic-max mic-max requested a review from a team June 2, 2022 22:20
@julianocosta89
Copy link
Member

The PR looks fine, I'd just check out the discussion going on at #89 to decide if the grpc_health_probe will be commited in the repo or downloaded in the Dockerfile.

src/paymentservice/README.md Outdated Show resolved Hide resolved
@mic-max mic-max marked this pull request as draft June 13, 2022 20:16
@mic-max mic-max changed the title grpc_health_probe change to the paymentservice Add Docker HEALTHCHECK to all services using the grpc_health_probe executable Jun 13, 2022
@mic-max mic-max marked this pull request as ready for review June 23, 2022 19:56
README.md Outdated Show resolved Hide resolved
@mic-max mic-max marked this pull request as draft June 28, 2022 18:11
@mic-max
Copy link
Contributor Author

mic-max commented Jun 28, 2022

Converting to draft while I rework this to not include the binary and instead have instructions for users to download the probe to the correct folder and also add a step to the CIs to download the executable.

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save a copy of grpc_health_probe binary to the repository
4 participants