You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Can we make a new "alias" makefile target to reduce the number of make command needed to run before submitting a PR, as specified in contributing.md?
Currently, it's
* Before submitting a PR, run the following commands from the root of the repository to ensure your new compone
nt is meeting the repo linting expectations:
* `make checkdoc`
* `make checkmetadata`
* `make checkapi`
* `make goporto`
* `make crosslink`
* `make gotidy`
* `make genotelcontribcol`
* `make genoteltestbedcol`
* `make generate`
* `make multimod-verify`
* `make generate-gh-issue-templates`
* `make addlicense`
Alternatively, we could make PR requirements a precommit hook, but that would require contributors setting up precommit. Given the "heft" of these commands, it'd probably better to specifically use a pre-pushhook
As an aside, it'd be nice to have a docs label or similar for issues like this.
The text was updated successfully, but these errors were encountered:
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.
Component(s)
No response
Describe the issue you're reporting
Can we make a new "alias" makefile target to reduce the number of make command needed to run before submitting a PR, as specified in contributing.md?
Currently, it's
but I'd rather have
Alternatively, we could make PR requirements a precommit hook, but that would require contributors setting up precommit. Given the "heft" of these commands, it'd probably better to specifically use a pre-push hook
As an aside, it'd be nice to have a
docs
label or similar for issues like this.The text was updated successfully, but these errors were encountered: