Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] make update-otel fails with minimal details #36219

Open
djaglowski opened this issue Nov 5, 2024 · 3 comments
Open

[release] make update-otel fails with minimal details #36219

djaglowski opened this issue Nov 5, 2024 · 3 comments
Labels
release-retro Issues discussed in a release retrospective Stale

Comments

@djaglowski
Copy link
Member

Component(s)

No response

Describe the issue you're reporting

In step 1 of the contrib release process, the following error occurs:

> make update-otel OTEL_VERSION=v0.113.0 OTEL_STABLE_VERSION=v1.19.0
...
2024-11-05T16:01:09.936-0500    INFO    builder/config.go:159   Using go        {"go-executable": "/opt/homebrew/bin/go"}
2024-11-05T16:01:09.938-0500    INFO    builder/main.go:100     Sources created {"path": "cmd/oteltestbedcol"}
2024-11-05T16:01:10.212-0500    INFO    builder/main.go:191     Getting go modules
2024-11-05T16:01:12.202-0500    INFO    builder/main.go:107     Generating source codes only, the distribution will not be compiled.
cd ./cmd/oteltestbedcol && GO111MODULE=on CGO_ENABLED=0 go build -trimpath -o ../../bin/oteltestbedcol_darwin_arm64 \
                -tags "" .
main module (github.com/open-telemetry/opentelemetry-collector-contrib) does not contain package github.com/open-telemetry/opentelemetry-collector-contrib/cmd/oteltestbedcol
make[1]: *** [oteltestbedcol] Error 1
make: *** [update-otel] Error 2
@djaglowski djaglowski added release:blocker The issue must be resolved before cutting the next release release-retro Issues discussed in a release retrospective and removed release:blocker The issue must be resolved before cutting the next release labels Nov 5, 2024
@djaglowski
Copy link
Member Author

This was due to having manually created a go work space in order to validate an earlier part of the release process, but not having deleted the workspace files. Ideally the process would not allow for manual mistake like this.

@mowies
Copy link
Member

mowies commented Nov 7, 2024

Are we already checking if the workdir is clean and without any uncommitted changes before this? That would be a low hanging fruit probably.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-retro Issues discussed in a release retrospective Stale
Projects
None yet
Development

No branches or pull requests

2 participants