refactor: clean todo comments #1178
Draft
+244
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CLIParameters: put it on document issue - IFilter: Explicitly explains the limitation in JavaDoc - LatexFilter: refactor logging as debug log - ProjectFactory: update comments - RealProject: explains in IFilter javadoc, so leave the pointer to IFilter in the comment. - Translator: make it public and update comment typos. Signed-off-by: Hiroshi Miura <[email protected]>
- BaseMainWindowMenu: it is original implementer's idea to load menu from a resource bundle. remove it. Signed-off-by: Hiroshi Miura <[email protected]>
- SpellcheckerConfigurationController: update comment with a description for a future direction of the implementation. - Extend IEditor to provide getCurrentPositionInEntryTranslationInEditor and move logic from SearchWindowController to EditorController Signed-off-by: Hiroshi Miura <[email protected]>
- HunspellTokenizer to implement stopWords Signed-off-by: Hiroshi Miura <[email protected]>
|
This becomes too big a change. I want to split and raise each as PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of TODO comments in the OmegaT source.
This PR is to clean it up with updating comments, put it to issue ticket, or update javadoc.
Pull request type
Please mark github LABEL of the type of change your PR introduces:
refactor
Which ticket is resolved?
What does this PR change?
Other information