Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: mentored projects #1190

Open
fdschmidt93 opened this issue Sep 1, 2021 · 3 comments
Open

FR: mentored projects #1190

fdschmidt93 opened this issue Sep 1, 2021 · 3 comments

Comments

@fdschmidt93
Copy link
Member

fdschmidt93 commented Sep 1, 2021

Hi all,

since core now engages in mentored projects, I was thinking telescope should maybe follow suit. To that end, here's a list of fixes/features/ideas loosely (and hopefully adequately) sorted from easy to hard the nvim-telescope team is happy to provide guidance on in a PR. Guidance means just open an issue or a first draft PR, lay out how you want to tackle the problem (further) and we'll do our best to help.

Topic Headline Complexity Prelim. Assignee Relevant issues Description
UI dynamic_preview_title truncate on left side Low #1167 dynamic_preview_title needs to be truncatable on the left so the end of the path can be displayed
Feat Composable LSP finders Low-mid #713 Provide action that bridges selected entry and other lsp finders/actions
Feat Picker for lua functions Mid Mentioned on reddit lua fn picker over _G analogous to builtin.commands
UI Highlight match in preview Mid #933 #1042
Feat Picker for tabpages Mid-high Mentioned on gitter Pick and preview tabpages; complexity primarily from previewer
Feat Return values from picker Mid-high #1159 Prior knowledge with (plenary) async recommended
Feat Keep Telescope open High comment Telescope as fuzzy quickfix list? Maybe needs discussion
Feat Combining pickers Very High #213

I'll do my best to keep this list up-to-date.

Here's how you'd start

  1. Fork the Project
  2. Create your Feature Branch (git checkout -b my_contribution)
  3. Make your changes
  4. Stage and commit your Changes (git add -u && git commit -m 'Add my contribution')
  5. Push to the Branch (git push origin my_contribution)
  6. Open a Pull Request by going to the project webpage; it'll then suggest to you to open a PR on telescope

Optionally, you can lay out your solution in the respective issues or a new feature request issue.

@fdschmidt93 fdschmidt93 added enhancement Enhancement to performance, inner workings or existent features and removed enhancement Enhancement to performance, inner workings or existent features labels Sep 1, 2021
@clason clason pinned this issue Sep 1, 2021
@TheLeoP
Copy link
Contributor

TheLeoP commented Sep 13, 2021

Hi.

I would like to start helping with some of this problems, but I'm a CS student and I have barely used github to manage my personal config repo, so I'm very lost about what should I do. I'm not even sure if this is the right place to ask for help about this 😅.

I have watched TJ's video about making a PR to Neovim, though. So I think I have to say I want to help on an issue (#1182 for example), clone the Telescope repo and start working on that (?).

Sorry for all the questions.

@fdschmidt93
Copy link
Member Author

fdschmidt93 commented Sep 13, 2021

Sorry for all the questions.

No need to apologize; everybody was starting out at some point!

Here's roughly how you'd start.

  1. Fork the Project
  2. Create your Feature Branch (git checkout -b my_contribution)
  3. Make your changes
  4. Stage and commit your Changes (git add -u && git commit -m 'Add my contribution')
  5. Push to the Branch (git push origin my_contribution)
  6. Open a Pull Request by going to the project webpage; it'll then suggest to you to open a PR on telescope

Let me know in case you run into any troubles; I think #1182 hopefully already largely lays out how to tackle the issue, if you have more questions don't hesitate to ping me there!

@max397574
Copy link
Contributor

I'll try working on the bottom_pane preview width @l-kershaw

@Conni2461 Conni2461 unpinned this issue May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants