Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate plugins help pages tags on install/update #145

Merged
merged 5 commits into from
Feb 12, 2024
Merged

feat: generate plugins help pages tags on install/update #145

merged 5 commits into from
Feb 12, 2024

Conversation

NTBBloodbath
Copy link
Member

This PR also adds a new configuration option called generate_help_pages, which defaults to true.

@NTBBloodbath
feat: generate plugins help pages tags on install/update
7706c3b 
Adds a new configuration option `generate_help_pages` which defaults to `true`.
@NTBBloodbath NTBBloodbath added the enhancement New feature or request label Feb 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 12, 2024 •
edited by NTBBloodbath
Loading

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

@NTBBloodbath
feat: generate plugins help pages tags on install/update
721d392 
Adds a new configuration option `generate_help_pages` which defaults to `true`.
@NTBBloodbath
Copy link
Member Author

Hmm I did a push --force because I had committed a typo before in a command and Git doesn't seem to care about the flag. It would be nice to do a squash

mrcjkb
mrcjkb requested changes Feb 12, 2024
View reviewed changes
lua/rocks/operations.lua Outdated Show resolved Hide resolved
lua/rocks/config/internal.lua Show resolved Hide resolved
NTBBloodbath and others added 3 commits February 12, 2024 09:00
@NTBBloodbath
ref(operations): re-generate help tags in add and sync instead of…
098f071 
… `install` to avoid re-generating them multiple times
@NTBBloodbath
fix(config): add missing generate_help_pages configuration option i…
3f50c46 
…n the user-facing configuration module
docs(generated): update doc/rocks.txt
122a4a6 
skip-checks: true
@vhyrro vhyrro requested a review from mrcjkb February 12, 2024 14:16
@mrcjkb
Copy link
Member

mrcjkb commented Feb 12, 2024

Weird that this isn't triggering CI...

@mrcjkb mrcjkb merged commit ab1f8c6 into master Feb 12, 2024
1 check passed
@mrcjkb mrcjkb deleted the gen-helptags branch February 12, 2024 17:14
@github-actions github-actions bot mentioned this pull request Feb 12, 2024
Merged
@mrcjkb mrcjkb mentioned this pull request Feb 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhyrro vhyrro vhyrro approved these changes

@mrcjkb mrcjkb mrcjkb approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NTBBloodbath @mrcjkb @vhyrro