Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to disable external icon in NavigationMenu #2996

Open
Ripwords opened this issue Dec 29, 2024 · 0 comments · May be fixed by #2997
Open

Ability to disable external icon in NavigationMenu #2996

Ripwords opened this issue Dec 29, 2024 · 0 comments · May be fixed by #2997
Labels
enhancement New feature or request triage v3 #1289

Comments

@Ripwords
Copy link

Ripwords commented Dec 29, 2024 •
edited
Loading

Description

I've been trying for some time to disable the external icon as shown here but was unable to, even if target="_blank":
Image

In this case, I want to display the icons as below without the external icons, even if the target='_blank':
Image

Additional context

The lines responsible identified here:

ui/src/runtime/components/NavigationMenu.vue

Line 191 in d4653e3

<UIcon v-if="item.target === '_blank'" :name="appConfig.ui.icons.external" :class="ui.linkLabelExternalIcon({ class: props.ui?.linkLabelExternalIcon, active })" />

ui/src/runtime/components/NavigationMenu.vue

Line 252 in d4653e3

<UIcon v-if="childItem.target === '_blank'" :name="appConfig.ui.icons.external" :class="ui.childLinkLabelExternalIcon({ class: props.ui?.childLinkLabelExternalIcon, active: childActive })" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request triage v3 #1289
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(NavigationMenu): Add hideExternalIcon property to control external icon visibility Ripwords/ui
1 participant
@Ripwords