-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export Your Images to SRGB #39
Comments
Oh and what I mean my images look like this is... So this is not somehow the output of the model....really just importing and exporting the image makes it look strange. |
So have you trained with sRGB photos? What's the output looks like? |
@JeremyAlain Thanks a lot for your reply. I will add this to the README. Thanks again. |
Thanks for your post, maybe I should export them to sRGB and train from scratch. @JeremyAlain |
Hi, this is because your monitor actually explain the images in ProPhoto color space using the sRGB cotor space. The difference between them can be found here (https://en.wikipedia.org/wiki/Gamut). You need to convert the color space from ProPhoto to sRGB to view the image correctly. |
Thanks a lot for the clarification. I was wrong then. @nothinglo, maybe change the Readme again |
@JeremyAlain could you provide archive with right "original" and "expert C" images? |
Could you please tell me how to convert the image from ProPhoto RGB to sRGB color space ? |
This can be achieved by first convert ProPhoto RGB to CIE XYZ then convert the CIE XYZ to sRGB. The conversion matrix can be found here http://brucelindbloom.com/index.html?Eqn_RGB_XYZ_Matrix.html. |
Thanks for your advice. I choose to export as sRGB from Lightroom directly. @HuiZeng |
Okay so it took me another few hours to figure that one out. I know that in a previous issue #38 we talked about exporting your images from Lightroom in ProPhotoRGB. This comes from the fact that the on the website of the Adobe 5K dataset (https://data.csail.mit.edu/graphics/fivek/) they say that they provide the images in ProPhotoRGB format.
BUT...when I use pro photo RGB my images look like this:
And the original label looks like this:
So after training the supervised model I get a very nice PSNR, but unfortunately the images look very strange...So even though Adobe says they use ProPhotoRGB images, in my case this does not work. I don't know if this is general or if this is specific to my case(as another user from #38 says he uses ProPhotoRGB). After googling around one also finds that sRGB is a format which makes the image independent of the screen...so that doesn't sound too bad an intuition why one should use it. Maybe try both.
The text was updated successfully, but these errors were encountered: