Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

processors/archive_webpages: skip rewriting the data file if archive_error: True and a new attempt also fails #131

Open
nodiscc opened this issue Dec 13, 2023 · 0 comments
Open

processors/archive_webpages: skip rewriting the data file if archive_error: True and a new attempt also fails #131

nodiscc opened this issue Dec 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@nodiscc
Copy link
Owner

nodiscc commented Dec 13, 2023

When re-attempting to archive an URL for which archive_error is True, and the new download attempt fails, the data file will be re-written to write the archive_error: True field.

However this is not needed (since the key is already set), and wastes time writing the temporary file and copying it back to the data file (especially with large data files).
@nodiscc nodiscc added the enhancement New feature or request label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nodiscc