Promise version of finished not calling clean up

[rhodgkins]

readable-stream/lib/internal/streams/end-of-stream.js

Lines 245 to 255 in e95c761

	function finished(stream, opts) {
	return new Promise((resolve, reject) => {
	eos(stream, opts, (err) => {
	if (err) {
	reject(err)
	} else {
	resolve()
	}
	})
	})
	}

Should the promise version of finished call the clean up function returned from the callback version?

So something like:

function finished(stream, opts) {
  return new Promise((resolve, reject) => {
    const cleanup = eos(stream, opts, (err) => {
      cleanup()
      if (err) {
        reject(err)
      } else {
        resolve()
      }
    })
  })
}

Also raised in the main repo nodejs/node#44556

[mcollina]

Closed in favor of nodejs/node#44556