-
Notifications
You must be signed in to change notification settings - Fork 6
Where do we want to put the hooks? #13
Comments
Isn't the discussion already happening in nodejs/node#21857? Why duplicate that discussion here? |
@misterdjules well, basically we like moving the conceptual discussion away from pull request and keep the technical discussion there. It also has a broader scope than just that PR and will have to go through the TSC themselves. It can also happen in nodejs/node (in an issue) if you prefer or elsewhere. |
I'm concerned that having this discussion in two different places is going to add to the confusion both here and in nodejs/node, without necessarily having any clear benefit. The conceptual discussion can happen in nodejs/node.
It's not clear to me how the scope of this issue is bigger than the scope of nodejs/node#21857
Do you mean that conversations that might escalate to the TSC cannot happen in nodejs/node? |
In terms of not wanting in on I guess I'm just starting the conversation of what you suggested we document. So +1 to that. |
Given the work on #8 that @devsnek is working on implementing in Node now - we need to figure out a place to put this hook (and the other ones that will hopefully be coming).
process
andPromise
and I agree it shouldn't be on either.We should think where we want to put this hook as well as other hooks that will be related to engine hooks and hooks related to debugging.
@nodejs/promises-debugging - ideas are welcome. Just to start the bikeshedding:
Should different hooks be different events?
The text was updated successfully, but these errors were encountered: