From cb3de78d7dac7b4de84889cbe8051bda3f789223 Mon Sep 17 00:00:00 2001 From: Gautam Arora Date: Tue, 18 Jul 2017 20:41:00 -0400 Subject: [PATCH 1/4] test: add comments for whatwg-url tests Added comments to whatwg-url tests that they should not be changed until modifications are merged upstream as per guidelines for [Web Platform Tests](https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#web-platform-tests) Fixes: #12793 --- doc/guides/writing-tests.md | 3 ++- test/fixtures/url-setter-tests.js | 3 ++- test/fixtures/url-tests.js | 3 ++- test/fixtures/url-toascii.js | 3 ++- test/parallel/test-whatwg-url-constructor.js | 3 ++- test/parallel/test-whatwg-url-historical.js | 3 ++- test/parallel/test-whatwg-url-origin.js | 3 ++- test/parallel/test-whatwg-url-searchparams-append.js | 3 ++- test/parallel/test-whatwg-url-searchparams-constructor.js | 3 ++- test/parallel/test-whatwg-url-searchparams-delete.js | 3 ++- test/parallel/test-whatwg-url-searchparams-foreach.js | 3 ++- test/parallel/test-whatwg-url-searchparams-get.js | 3 ++- test/parallel/test-whatwg-url-searchparams-getall.js | 3 ++- test/parallel/test-whatwg-url-searchparams-has.js | 3 ++- test/parallel/test-whatwg-url-searchparams-set.js | 3 ++- test/parallel/test-whatwg-url-searchparams-sort.js | 3 ++- test/parallel/test-whatwg-url-searchparams-stringifier.js | 3 ++- test/parallel/test-whatwg-url-setters.js | 3 ++- test/parallel/test-whatwg-url-toascii.js | 3 ++- test/parallel/test-whatwg-url-tojson.js | 3 ++- 20 files changed, 40 insertions(+), 20 deletions(-) diff --git a/doc/guides/writing-tests.md b/doc/guides/writing-tests.md index 9d226da6e804a9..bd7d8803606ced 100644 --- a/doc/guides/writing-tests.md +++ b/doc/guides/writing-tests.md @@ -264,7 +264,8 @@ These imported tests will be wrapped like this: ```js /* eslint-disable */ -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-stringifier.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/fixtures/url-setter-tests.js b/test/fixtures/url-setter-tests.js index 923110d9364132..f460538bf3dba2 100644 --- a/test/fixtures/url-setter-tests.js +++ b/test/fixtures/url-setter-tests.js @@ -1,6 +1,7 @@ 'use strict'; -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/b30abaecf4/url/setters_tests.json License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/fixtures/url-tests.js b/test/fixtures/url-tests.js index 00643f961321df..589e13a218a327 100644 --- a/test/fixtures/url-tests.js +++ b/test/fixtures/url-tests.js @@ -1,6 +1,7 @@ 'use strict'; -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/8df7c9c215/url/urltestdata.json License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/fixtures/url-toascii.js b/test/fixtures/url-toascii.js index ea5e0f22ba1b5f..97fbef163a69c2 100644 --- a/test/fixtures/url-toascii.js +++ b/test/fixtures/url-toascii.js @@ -1,6 +1,7 @@ 'use strict'; -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/4839a0a804/url/toascii.json License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-constructor.js b/test/parallel/test-whatwg-url-constructor.js index 290f9266b54f41..112b9597a2521b 100644 --- a/test/parallel/test-whatwg-url-constructor.js +++ b/test/parallel/test-whatwg-url-constructor.js @@ -15,7 +15,8 @@ const request = { }; /* eslint-disable */ -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/url-constructor.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-historical.js b/test/parallel/test-whatwg-url-historical.js index 7848b1c1873a70..18a2fe01898fd3 100644 --- a/test/parallel/test-whatwg-url-historical.js +++ b/test/parallel/test-whatwg-url-historical.js @@ -9,7 +9,8 @@ const URL = require('url').URL; const { test, assert_equals, assert_throws } = require('../common/wpt'); /* eslint-disable */ -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/historical.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-origin.js b/test/parallel/test-whatwg-url-origin.js index 732100e142a509..dc0a1d7d44654c 100644 --- a/test/parallel/test-whatwg-url-origin.js +++ b/test/parallel/test-whatwg-url-origin.js @@ -14,7 +14,8 @@ const request = { }; /* eslint-disable */ -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/url-origin.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-append.js b/test/parallel/test-whatwg-url-searchparams-append.js index d9534a2209ddfe..36f0f30d7a04d5 100644 --- a/test/parallel/test-whatwg-url-searchparams-append.js +++ b/test/parallel/test-whatwg-url-searchparams-append.js @@ -6,7 +6,8 @@ const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals, assert_true } = require('../common/wpt'); /* eslint-disable */ -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-append.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-constructor.js b/test/parallel/test-whatwg-url-searchparams-constructor.js index 4a549c842b1942..34671f90d1a982 100644 --- a/test/parallel/test-whatwg-url-searchparams-constructor.js +++ b/test/parallel/test-whatwg-url-searchparams-constructor.js @@ -10,7 +10,8 @@ const { /* eslint-disable */ var params; // Strict mode fix for WPT. -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/54c3502d7b/url/urlsearchparams-constructor.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-delete.js b/test/parallel/test-whatwg-url-searchparams-delete.js index dae0b338ddae55..7edd94919c7f33 100644 --- a/test/parallel/test-whatwg-url-searchparams-delete.js +++ b/test/parallel/test-whatwg-url-searchparams-delete.js @@ -7,7 +7,8 @@ const { test, assert_equals, assert_true, assert_false } = require('../common/wpt'); /* eslint-disable */ -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-delete.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-foreach.js b/test/parallel/test-whatwg-url-searchparams-foreach.js index 6135f356387289..5f2d296146e448 100644 --- a/test/parallel/test-whatwg-url-searchparams-foreach.js +++ b/test/parallel/test-whatwg-url-searchparams-foreach.js @@ -8,7 +8,8 @@ const { test, assert_array_equals, assert_unreached } = /* eslint-disable */ var i; // Strict mode fix for WPT. -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/a8b2b1e/url/urlsearchparams-foreach.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-get.js b/test/parallel/test-whatwg-url-searchparams-get.js index a49cc2c2b0d0c0..8f3f5024c2dceb 100644 --- a/test/parallel/test-whatwg-url-searchparams-get.js +++ b/test/parallel/test-whatwg-url-searchparams-get.js @@ -6,7 +6,8 @@ const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals, assert_true } = require('../common/wpt'); /* eslint-disable */ -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-get.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-getall.js b/test/parallel/test-whatwg-url-searchparams-getall.js index bf287d52a01cd8..fa76bcefee28af 100644 --- a/test/parallel/test-whatwg-url-searchparams-getall.js +++ b/test/parallel/test-whatwg-url-searchparams-getall.js @@ -7,7 +7,8 @@ const { test, assert_equals, assert_true, assert_array_equals } = require('../common/wpt'); /* eslint-disable */ -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-getall.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-has.js b/test/parallel/test-whatwg-url-searchparams-has.js index 127e1a8329bffc..d31320e21cbad5 100644 --- a/test/parallel/test-whatwg-url-searchparams-has.js +++ b/test/parallel/test-whatwg-url-searchparams-has.js @@ -6,7 +6,8 @@ const URLSearchParams = require('url').URLSearchParams; const { test, assert_false, assert_true } = require('../common/wpt'); /* eslint-disable */ -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-has.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-set.js b/test/parallel/test-whatwg-url-searchparams-set.js index f7620c05d12e6e..4ee02d0fc31300 100644 --- a/test/parallel/test-whatwg-url-searchparams-set.js +++ b/test/parallel/test-whatwg-url-searchparams-set.js @@ -6,7 +6,8 @@ const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals, assert_true } = require('../common/wpt'); /* eslint-disable */ -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-set.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-sort.js b/test/parallel/test-whatwg-url-searchparams-sort.js index adc34976047522..6535a8f9c7bccc 100644 --- a/test/parallel/test-whatwg-url-searchparams-sort.js +++ b/test/parallel/test-whatwg-url-searchparams-sort.js @@ -5,7 +5,8 @@ const { URL, URLSearchParams } = require('url'); const { test, assert_array_equals } = require('../common/wpt'); /* eslint-disable */ -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/5903e00e77e85f8bcb21c73d1d7819fcd04763bd/url/urlsearchparams-sort.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-stringifier.js b/test/parallel/test-whatwg-url-searchparams-stringifier.js index 7162932546f233..da7ba6c3692336 100644 --- a/test/parallel/test-whatwg-url-searchparams-stringifier.js +++ b/test/parallel/test-whatwg-url-searchparams-stringifier.js @@ -6,7 +6,8 @@ const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals } = require('../common/wpt'); /* eslint-disable */ -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-stringifier.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-setters.js b/test/parallel/test-whatwg-url-setters.js index 938c2aa2538765..2de2cda9c510ef 100644 --- a/test/parallel/test-whatwg-url-setters.js +++ b/test/parallel/test-whatwg-url-setters.js @@ -18,7 +18,8 @@ const request = { }; /* eslint-disable */ -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/url-setters.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-toascii.js b/test/parallel/test-whatwg-url-toascii.js index 851240ce650a70..8effeefd864471 100644 --- a/test/parallel/test-whatwg-url-toascii.js +++ b/test/parallel/test-whatwg-url-toascii.js @@ -14,7 +14,8 @@ const request = { }; /* eslint-disable */ -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/4839a0a804/url/toascii.window.js License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-tojson.js b/test/parallel/test-whatwg-url-tojson.js index 5a90fdd27f3978..3d161043d4891e 100644 --- a/test/parallel/test-whatwg-url-tojson.js +++ b/test/parallel/test-whatwg-url-tojson.js @@ -5,7 +5,8 @@ const URL = require('url').URL; const { test, assert_equals } = require('../common/wpt'); /* eslint-disable */ -/* WPT Refs: +/* The following tests are copied from WPT, modifications to them should be upstreamed first. + Refs: https://github.com/w3c/web-platform-tests/blob/02585db/url/url-tojson.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ From 7b630485e2acbf62d9502062e28c5fd4ca8fc5e7 Mon Sep 17 00:00:00 2001 From: Gautam Arora Date: Tue, 18 Jul 2017 21:06:21 -0400 Subject: [PATCH 2/4] test: fix to keep lines under 80 chars --- doc/guides/writing-tests.md | 4 ++-- test/fixtures/url-setter-tests.js | 4 ++-- test/fixtures/url-tests.js | 4 ++-- test/fixtures/url-toascii.js | 4 ++-- test/parallel/test-whatwg-url-constructor.js | 4 ++-- test/parallel/test-whatwg-url-historical.js | 4 ++-- test/parallel/test-whatwg-url-origin.js | 4 ++-- test/parallel/test-whatwg-url-searchparams-append.js | 4 ++-- test/parallel/test-whatwg-url-searchparams-constructor.js | 4 ++-- test/parallel/test-whatwg-url-searchparams-delete.js | 4 ++-- test/parallel/test-whatwg-url-searchparams-foreach.js | 4 ++-- test/parallel/test-whatwg-url-searchparams-get.js | 4 ++-- test/parallel/test-whatwg-url-searchparams-getall.js | 4 ++-- test/parallel/test-whatwg-url-searchparams-has.js | 4 ++-- test/parallel/test-whatwg-url-searchparams-set.js | 4 ++-- test/parallel/test-whatwg-url-searchparams-sort.js | 4 ++-- test/parallel/test-whatwg-url-searchparams-stringifier.js | 4 ++-- test/parallel/test-whatwg-url-setters.js | 4 ++-- test/parallel/test-whatwg-url-toascii.js | 4 ++-- test/parallel/test-whatwg-url-tojson.js | 4 ++-- 20 files changed, 40 insertions(+), 40 deletions(-) diff --git a/doc/guides/writing-tests.md b/doc/guides/writing-tests.md index bd7d8803606ced..305457090084ae 100644 --- a/doc/guides/writing-tests.md +++ b/doc/guides/writing-tests.md @@ -264,8 +264,8 @@ These imported tests will be wrapped like this: ```js /* eslint-disable */ -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-stringifier.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/fixtures/url-setter-tests.js b/test/fixtures/url-setter-tests.js index f460538bf3dba2..faa055c105f0c3 100644 --- a/test/fixtures/url-setter-tests.js +++ b/test/fixtures/url-setter-tests.js @@ -1,7 +1,7 @@ 'use strict'; -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/b30abaecf4/url/setters_tests.json License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/fixtures/url-tests.js b/test/fixtures/url-tests.js index 589e13a218a327..475a7223904687 100644 --- a/test/fixtures/url-tests.js +++ b/test/fixtures/url-tests.js @@ -1,7 +1,7 @@ 'use strict'; -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8df7c9c215/url/urltestdata.json License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/fixtures/url-toascii.js b/test/fixtures/url-toascii.js index 97fbef163a69c2..fb6fe2f50fd8fa 100644 --- a/test/fixtures/url-toascii.js +++ b/test/fixtures/url-toascii.js @@ -1,7 +1,7 @@ 'use strict'; -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/4839a0a804/url/toascii.json License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-constructor.js b/test/parallel/test-whatwg-url-constructor.js index 112b9597a2521b..9258f11fab3b17 100644 --- a/test/parallel/test-whatwg-url-constructor.js +++ b/test/parallel/test-whatwg-url-constructor.js @@ -15,8 +15,8 @@ const request = { }; /* eslint-disable */ -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/url-constructor.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-historical.js b/test/parallel/test-whatwg-url-historical.js index 18a2fe01898fd3..c12365c44e515a 100644 --- a/test/parallel/test-whatwg-url-historical.js +++ b/test/parallel/test-whatwg-url-historical.js @@ -9,8 +9,8 @@ const URL = require('url').URL; const { test, assert_equals, assert_throws } = require('../common/wpt'); /* eslint-disable */ -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/historical.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-origin.js b/test/parallel/test-whatwg-url-origin.js index dc0a1d7d44654c..365a0a8e3de355 100644 --- a/test/parallel/test-whatwg-url-origin.js +++ b/test/parallel/test-whatwg-url-origin.js @@ -14,8 +14,8 @@ const request = { }; /* eslint-disable */ -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/url-origin.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-append.js b/test/parallel/test-whatwg-url-searchparams-append.js index 36f0f30d7a04d5..705c944888a126 100644 --- a/test/parallel/test-whatwg-url-searchparams-append.js +++ b/test/parallel/test-whatwg-url-searchparams-append.js @@ -6,8 +6,8 @@ const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals, assert_true } = require('../common/wpt'); /* eslint-disable */ -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-append.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-constructor.js b/test/parallel/test-whatwg-url-searchparams-constructor.js index 34671f90d1a982..918b442a1766cd 100644 --- a/test/parallel/test-whatwg-url-searchparams-constructor.js +++ b/test/parallel/test-whatwg-url-searchparams-constructor.js @@ -10,8 +10,8 @@ const { /* eslint-disable */ var params; // Strict mode fix for WPT. -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/54c3502d7b/url/urlsearchparams-constructor.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-delete.js b/test/parallel/test-whatwg-url-searchparams-delete.js index 7edd94919c7f33..3ea0445676835f 100644 --- a/test/parallel/test-whatwg-url-searchparams-delete.js +++ b/test/parallel/test-whatwg-url-searchparams-delete.js @@ -7,8 +7,8 @@ const { test, assert_equals, assert_true, assert_false } = require('../common/wpt'); /* eslint-disable */ -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-delete.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-foreach.js b/test/parallel/test-whatwg-url-searchparams-foreach.js index 5f2d296146e448..f30d7a3ff4e0d7 100644 --- a/test/parallel/test-whatwg-url-searchparams-foreach.js +++ b/test/parallel/test-whatwg-url-searchparams-foreach.js @@ -8,8 +8,8 @@ const { test, assert_array_equals, assert_unreached } = /* eslint-disable */ var i; // Strict mode fix for WPT. -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/a8b2b1e/url/urlsearchparams-foreach.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-get.js b/test/parallel/test-whatwg-url-searchparams-get.js index 8f3f5024c2dceb..b217e4bad28e74 100644 --- a/test/parallel/test-whatwg-url-searchparams-get.js +++ b/test/parallel/test-whatwg-url-searchparams-get.js @@ -6,8 +6,8 @@ const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals, assert_true } = require('../common/wpt'); /* eslint-disable */ -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-get.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-getall.js b/test/parallel/test-whatwg-url-searchparams-getall.js index fa76bcefee28af..12e479cf40cbe3 100644 --- a/test/parallel/test-whatwg-url-searchparams-getall.js +++ b/test/parallel/test-whatwg-url-searchparams-getall.js @@ -7,8 +7,8 @@ const { test, assert_equals, assert_true, assert_array_equals } = require('../common/wpt'); /* eslint-disable */ -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-getall.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-has.js b/test/parallel/test-whatwg-url-searchparams-has.js index d31320e21cbad5..654e700e05ff84 100644 --- a/test/parallel/test-whatwg-url-searchparams-has.js +++ b/test/parallel/test-whatwg-url-searchparams-has.js @@ -6,8 +6,8 @@ const URLSearchParams = require('url').URLSearchParams; const { test, assert_false, assert_true } = require('../common/wpt'); /* eslint-disable */ -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-has.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-set.js b/test/parallel/test-whatwg-url-searchparams-set.js index 4ee02d0fc31300..61f526b942fb6e 100644 --- a/test/parallel/test-whatwg-url-searchparams-set.js +++ b/test/parallel/test-whatwg-url-searchparams-set.js @@ -6,8 +6,8 @@ const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals, assert_true } = require('../common/wpt'); /* eslint-disable */ -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-set.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-sort.js b/test/parallel/test-whatwg-url-searchparams-sort.js index 6535a8f9c7bccc..dceb262f3cf680 100644 --- a/test/parallel/test-whatwg-url-searchparams-sort.js +++ b/test/parallel/test-whatwg-url-searchparams-sort.js @@ -5,8 +5,8 @@ const { URL, URLSearchParams } = require('url'); const { test, assert_array_equals } = require('../common/wpt'); /* eslint-disable */ -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/5903e00e77e85f8bcb21c73d1d7819fcd04763bd/url/urlsearchparams-sort.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-searchparams-stringifier.js b/test/parallel/test-whatwg-url-searchparams-stringifier.js index da7ba6c3692336..0718496b3e9f8a 100644 --- a/test/parallel/test-whatwg-url-searchparams-stringifier.js +++ b/test/parallel/test-whatwg-url-searchparams-stringifier.js @@ -6,8 +6,8 @@ const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals } = require('../common/wpt'); /* eslint-disable */ -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-stringifier.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-setters.js b/test/parallel/test-whatwg-url-setters.js index 2de2cda9c510ef..ba054f5b7ed1fa 100644 --- a/test/parallel/test-whatwg-url-setters.js +++ b/test/parallel/test-whatwg-url-setters.js @@ -18,8 +18,8 @@ const request = { }; /* eslint-disable */ -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/url-setters.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-toascii.js b/test/parallel/test-whatwg-url-toascii.js index 8effeefd864471..a98fb7b3259c46 100644 --- a/test/parallel/test-whatwg-url-toascii.js +++ b/test/parallel/test-whatwg-url-toascii.js @@ -14,8 +14,8 @@ const request = { }; /* eslint-disable */ -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/4839a0a804/url/toascii.window.js License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ diff --git a/test/parallel/test-whatwg-url-tojson.js b/test/parallel/test-whatwg-url-tojson.js index 3d161043d4891e..af0991de96e3cf 100644 --- a/test/parallel/test-whatwg-url-tojson.js +++ b/test/parallel/test-whatwg-url-tojson.js @@ -5,8 +5,8 @@ const URL = require('url').URL; const { test, assert_equals } = require('../common/wpt'); /* eslint-disable */ -/* The following tests are copied from WPT, modifications to them should be upstreamed first. - Refs: +/* The following tests are copied from WPT, modifications to them should be + upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/02585db/url/url-tojson.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ From 7937fde7e2c904e87ecaa24f4089bc2d23986e96 Mon Sep 17 00:00:00 2001 From: Gautam Arora Date: Wed, 19 Jul 2017 00:01:33 -0400 Subject: [PATCH 3/4] test: move eslint disable to after comments --- doc/guides/writing-tests.md | 2 +- test/parallel/test-whatwg-url-constructor.js | 2 +- test/parallel/test-whatwg-url-historical.js | 2 +- test/parallel/test-whatwg-url-origin.js | 2 +- test/parallel/test-whatwg-url-searchparams-append.js | 2 +- test/parallel/test-whatwg-url-searchparams-constructor.js | 4 ++-- test/parallel/test-whatwg-url-searchparams-delete.js | 2 +- test/parallel/test-whatwg-url-searchparams-foreach.js | 4 ++-- test/parallel/test-whatwg-url-searchparams-get.js | 2 +- test/parallel/test-whatwg-url-searchparams-getall.js | 2 +- test/parallel/test-whatwg-url-searchparams-has.js | 2 +- test/parallel/test-whatwg-url-searchparams-set.js | 2 +- test/parallel/test-whatwg-url-searchparams-sort.js | 2 +- test/parallel/test-whatwg-url-searchparams-stringifier.js | 2 +- test/parallel/test-whatwg-url-setters.js | 2 +- test/parallel/test-whatwg-url-toascii.js | 2 +- test/parallel/test-whatwg-url-tojson.js | 2 +- 17 files changed, 19 insertions(+), 19 deletions(-) diff --git a/doc/guides/writing-tests.md b/doc/guides/writing-tests.md index 305457090084ae..b9db8041376170 100644 --- a/doc/guides/writing-tests.md +++ b/doc/guides/writing-tests.md @@ -263,12 +263,12 @@ Some of the tests for the WHATWG URL implementation (named These imported tests will be wrapped like this: ```js -/* eslint-disable */ /* The following tests are copied from WPT, modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-stringifier.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ +/* eslint-disable */ // Test code diff --git a/test/parallel/test-whatwg-url-constructor.js b/test/parallel/test-whatwg-url-constructor.js index 9258f11fab3b17..6c40b8094233d6 100644 --- a/test/parallel/test-whatwg-url-constructor.js +++ b/test/parallel/test-whatwg-url-constructor.js @@ -14,12 +14,12 @@ const request = { response: require(path.join(common.fixturesDir, 'url-tests')) }; -/* eslint-disable */ /* The following tests are copied from WPT, modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/url-constructor.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ +/* eslint-disable */ function runURLConstructorTests() { // var setup = async_test("Loading data…") // setup.step(function() { diff --git a/test/parallel/test-whatwg-url-historical.js b/test/parallel/test-whatwg-url-historical.js index c12365c44e515a..344815241222c8 100644 --- a/test/parallel/test-whatwg-url-historical.js +++ b/test/parallel/test-whatwg-url-historical.js @@ -8,12 +8,12 @@ if (!common.hasIntl) { const URL = require('url').URL; const { test, assert_equals, assert_throws } = require('../common/wpt'); -/* eslint-disable */ /* The following tests are copied from WPT, modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/historical.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ +/* eslint-disable */ // var objects = [ // [function() { return window.location }, "location object"], // [function() { return document.createElement("a") }, "a element"], diff --git a/test/parallel/test-whatwg-url-origin.js b/test/parallel/test-whatwg-url-origin.js index 365a0a8e3de355..730087127a59b1 100644 --- a/test/parallel/test-whatwg-url-origin.js +++ b/test/parallel/test-whatwg-url-origin.js @@ -13,12 +13,12 @@ const request = { response: require(path.join(common.fixturesDir, 'url-tests')) }; -/* eslint-disable */ /* The following tests are copied from WPT, modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/url-origin.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ +/* eslint-disable */ function runURLOriginTests() { // var setup = async_test("Loading data…") // setup.step(function() { diff --git a/test/parallel/test-whatwg-url-searchparams-append.js b/test/parallel/test-whatwg-url-searchparams-append.js index 705c944888a126..9d1c0eda49b053 100644 --- a/test/parallel/test-whatwg-url-searchparams-append.js +++ b/test/parallel/test-whatwg-url-searchparams-append.js @@ -5,12 +5,12 @@ const assert = require('assert'); const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals, assert_true } = require('../common/wpt'); -/* eslint-disable */ /* The following tests are copied from WPT, modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-append.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ +/* eslint-disable */ test(function() { var params = new URLSearchParams(); params.append('a', 'b'); diff --git a/test/parallel/test-whatwg-url-searchparams-constructor.js b/test/parallel/test-whatwg-url-searchparams-constructor.js index 918b442a1766cd..4737fa7c7bef1c 100644 --- a/test/parallel/test-whatwg-url-searchparams-constructor.js +++ b/test/parallel/test-whatwg-url-searchparams-constructor.js @@ -8,13 +8,13 @@ const { assert_false, assert_throws, assert_array_equals } = require('../common/wpt'); -/* eslint-disable */ -var params; // Strict mode fix for WPT. /* The following tests are copied from WPT, modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/54c3502d7b/url/urlsearchparams-constructor.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ +/* eslint-disable */ +var params; // Strict mode fix for WPT. test(function() { var params = new URLSearchParams(); assert_equals(params + '', ''); diff --git a/test/parallel/test-whatwg-url-searchparams-delete.js b/test/parallel/test-whatwg-url-searchparams-delete.js index 3ea0445676835f..66d59e71ddc9e4 100644 --- a/test/parallel/test-whatwg-url-searchparams-delete.js +++ b/test/parallel/test-whatwg-url-searchparams-delete.js @@ -6,12 +6,12 @@ const { URL, URLSearchParams } = require('url'); const { test, assert_equals, assert_true, assert_false } = require('../common/wpt'); -/* eslint-disable */ /* The following tests are copied from WPT, modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-delete.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ +/* eslint-disable */ test(function() { var params = new URLSearchParams('a=b&c=d'); params.delete('a'); diff --git a/test/parallel/test-whatwg-url-searchparams-foreach.js b/test/parallel/test-whatwg-url-searchparams-foreach.js index f30d7a3ff4e0d7..0fd0b3c329459b 100644 --- a/test/parallel/test-whatwg-url-searchparams-foreach.js +++ b/test/parallel/test-whatwg-url-searchparams-foreach.js @@ -6,13 +6,13 @@ const { URL, URLSearchParams } = require('url'); const { test, assert_array_equals, assert_unreached } = require('../common/wpt'); -/* eslint-disable */ -var i; // Strict mode fix for WPT. /* The following tests are copied from WPT, modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/a8b2b1e/url/urlsearchparams-foreach.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ +/* eslint-disable */ +var i; // Strict mode fix for WPT. test(function() { var params = new URLSearchParams('a=1&b=2&c=3'); var keys = []; diff --git a/test/parallel/test-whatwg-url-searchparams-get.js b/test/parallel/test-whatwg-url-searchparams-get.js index b217e4bad28e74..0433b12a124e72 100644 --- a/test/parallel/test-whatwg-url-searchparams-get.js +++ b/test/parallel/test-whatwg-url-searchparams-get.js @@ -5,12 +5,12 @@ const assert = require('assert'); const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals, assert_true } = require('../common/wpt'); -/* eslint-disable */ /* The following tests are copied from WPT, modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-get.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ +/* eslint-disable */ test(function() { var params = new URLSearchParams('a=b&c=d'); assert_equals(params.get('a'), 'b'); diff --git a/test/parallel/test-whatwg-url-searchparams-getall.js b/test/parallel/test-whatwg-url-searchparams-getall.js index 12e479cf40cbe3..5623f2cecaef16 100644 --- a/test/parallel/test-whatwg-url-searchparams-getall.js +++ b/test/parallel/test-whatwg-url-searchparams-getall.js @@ -6,12 +6,12 @@ const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals, assert_true, assert_array_equals } = require('../common/wpt'); -/* eslint-disable */ /* The following tests are copied from WPT, modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-getall.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ +/* eslint-disable */ test(function() { var params = new URLSearchParams('a=b&c=d'); assert_array_equals(params.getAll('a'), ['b']); diff --git a/test/parallel/test-whatwg-url-searchparams-has.js b/test/parallel/test-whatwg-url-searchparams-has.js index 654e700e05ff84..e33491a86cf59a 100644 --- a/test/parallel/test-whatwg-url-searchparams-has.js +++ b/test/parallel/test-whatwg-url-searchparams-has.js @@ -5,12 +5,12 @@ const assert = require('assert'); const URLSearchParams = require('url').URLSearchParams; const { test, assert_false, assert_true } = require('../common/wpt'); -/* eslint-disable */ /* The following tests are copied from WPT, modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-has.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ +/* eslint-disable */ test(function() { var params = new URLSearchParams('a=b&c=d'); assert_true(params.has('a')); diff --git a/test/parallel/test-whatwg-url-searchparams-set.js b/test/parallel/test-whatwg-url-searchparams-set.js index 61f526b942fb6e..ba1e88450ede0b 100644 --- a/test/parallel/test-whatwg-url-searchparams-set.js +++ b/test/parallel/test-whatwg-url-searchparams-set.js @@ -5,12 +5,12 @@ const assert = require('assert'); const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals, assert_true } = require('../common/wpt'); -/* eslint-disable */ /* The following tests are copied from WPT, modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-set.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ +/* eslint-disable */ test(function() { var params = new URLSearchParams('a=b&c=d'); params.set('a', 'B'); diff --git a/test/parallel/test-whatwg-url-searchparams-sort.js b/test/parallel/test-whatwg-url-searchparams-sort.js index dceb262f3cf680..f2bf042d9cd2a4 100644 --- a/test/parallel/test-whatwg-url-searchparams-sort.js +++ b/test/parallel/test-whatwg-url-searchparams-sort.js @@ -4,12 +4,12 @@ require('../common'); const { URL, URLSearchParams } = require('url'); const { test, assert_array_equals } = require('../common/wpt'); -/* eslint-disable */ /* The following tests are copied from WPT, modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/5903e00e77e85f8bcb21c73d1d7819fcd04763bd/url/urlsearchparams-sort.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ +/* eslint-disable */ [ { "input": "z=b&a=b&z=a&a=a", diff --git a/test/parallel/test-whatwg-url-searchparams-stringifier.js b/test/parallel/test-whatwg-url-searchparams-stringifier.js index 0718496b3e9f8a..7d8f8e5bc794c4 100644 --- a/test/parallel/test-whatwg-url-searchparams-stringifier.js +++ b/test/parallel/test-whatwg-url-searchparams-stringifier.js @@ -5,12 +5,12 @@ const assert = require('assert'); const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals } = require('../common/wpt'); -/* eslint-disable */ /* The following tests are copied from WPT, modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-stringifier.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ +/* eslint-disable */ test(function() { var params = new URLSearchParams(); params.append('a', 'b c'); diff --git a/test/parallel/test-whatwg-url-setters.js b/test/parallel/test-whatwg-url-setters.js index ba054f5b7ed1fa..40ba95ac4be49d 100644 --- a/test/parallel/test-whatwg-url-setters.js +++ b/test/parallel/test-whatwg-url-setters.js @@ -17,12 +17,12 @@ const request = { response: require(path.join(common.fixturesDir, 'url-setter-tests')) }; -/* eslint-disable */ /* The following tests are copied from WPT, modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/url-setters.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ +/* eslint-disable */ function startURLSettersTests() { // var setup = async_test("Loading data…") // setup.step(function() { diff --git a/test/parallel/test-whatwg-url-toascii.js b/test/parallel/test-whatwg-url-toascii.js index a98fb7b3259c46..2ee65712d1420a 100644 --- a/test/parallel/test-whatwg-url-toascii.js +++ b/test/parallel/test-whatwg-url-toascii.js @@ -13,12 +13,12 @@ const request = { response: require(path.join(common.fixturesDir, 'url-toascii')) }; -/* eslint-disable */ /* The following tests are copied from WPT, modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/4839a0a804/url/toascii.window.js License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ +/* eslint-disable */ // async_test(t => { // const request = new XMLHttpRequest() // request.open("GET", "toascii.json") diff --git a/test/parallel/test-whatwg-url-tojson.js b/test/parallel/test-whatwg-url-tojson.js index af0991de96e3cf..6d4b5cbf7efd90 100644 --- a/test/parallel/test-whatwg-url-tojson.js +++ b/test/parallel/test-whatwg-url-tojson.js @@ -4,12 +4,12 @@ require('../common'); const URL = require('url').URL; const { test, assert_equals } = require('../common/wpt'); -/* eslint-disable */ /* The following tests are copied from WPT, modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/02585db/url/url-tojson.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html */ +/* eslint-disable */ test(() => { const a = new URL("https://example.com/") assert_equals(JSON.stringify(a), "\"https://example.com/\"") From 7ae90c5f5ce523ee7c32a4e80b9145953a1cee39 Mon Sep 17 00:00:00 2001 From: Gautam Arora Date: Wed, 19 Jul 2017 01:08:41 -0400 Subject: [PATCH 4/4] test: replacing comma with period in comments --- doc/guides/writing-tests.md | 2 +- test/fixtures/url-setter-tests.js | 2 +- test/fixtures/url-tests.js | 2 +- test/fixtures/url-toascii.js | 2 +- test/parallel/test-whatwg-url-constructor.js | 2 +- test/parallel/test-whatwg-url-historical.js | 2 +- test/parallel/test-whatwg-url-origin.js | 2 +- test/parallel/test-whatwg-url-searchparams-append.js | 2 +- test/parallel/test-whatwg-url-searchparams-constructor.js | 2 +- test/parallel/test-whatwg-url-searchparams-delete.js | 2 +- test/parallel/test-whatwg-url-searchparams-foreach.js | 2 +- test/parallel/test-whatwg-url-searchparams-get.js | 2 +- test/parallel/test-whatwg-url-searchparams-getall.js | 2 +- test/parallel/test-whatwg-url-searchparams-has.js | 2 +- test/parallel/test-whatwg-url-searchparams-set.js | 2 +- test/parallel/test-whatwg-url-searchparams-sort.js | 2 +- test/parallel/test-whatwg-url-searchparams-stringifier.js | 2 +- test/parallel/test-whatwg-url-setters.js | 2 +- test/parallel/test-whatwg-url-toascii.js | 2 +- test/parallel/test-whatwg-url-tojson.js | 2 +- 20 files changed, 20 insertions(+), 20 deletions(-) diff --git a/doc/guides/writing-tests.md b/doc/guides/writing-tests.md index b9db8041376170..8c5c2b74556447 100644 --- a/doc/guides/writing-tests.md +++ b/doc/guides/writing-tests.md @@ -263,7 +263,7 @@ Some of the tests for the WHATWG URL implementation (named These imported tests will be wrapped like this: ```js -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-stringifier.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/fixtures/url-setter-tests.js b/test/fixtures/url-setter-tests.js index faa055c105f0c3..6f769eaec7543d 100644 --- a/test/fixtures/url-setter-tests.js +++ b/test/fixtures/url-setter-tests.js @@ -1,6 +1,6 @@ 'use strict'; -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/b30abaecf4/url/setters_tests.json License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/fixtures/url-tests.js b/test/fixtures/url-tests.js index 475a7223904687..b36e2be3e49ed6 100644 --- a/test/fixtures/url-tests.js +++ b/test/fixtures/url-tests.js @@ -1,6 +1,6 @@ 'use strict'; -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8df7c9c215/url/urltestdata.json License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/fixtures/url-toascii.js b/test/fixtures/url-toascii.js index fb6fe2f50fd8fa..59b76330f867f2 100644 --- a/test/fixtures/url-toascii.js +++ b/test/fixtures/url-toascii.js @@ -1,6 +1,6 @@ 'use strict'; -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/4839a0a804/url/toascii.json License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/parallel/test-whatwg-url-constructor.js b/test/parallel/test-whatwg-url-constructor.js index 6c40b8094233d6..38be3a293b9fcf 100644 --- a/test/parallel/test-whatwg-url-constructor.js +++ b/test/parallel/test-whatwg-url-constructor.js @@ -14,7 +14,7 @@ const request = { response: require(path.join(common.fixturesDir, 'url-tests')) }; -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/url-constructor.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/parallel/test-whatwg-url-historical.js b/test/parallel/test-whatwg-url-historical.js index 344815241222c8..466949cd322d37 100644 --- a/test/parallel/test-whatwg-url-historical.js +++ b/test/parallel/test-whatwg-url-historical.js @@ -8,7 +8,7 @@ if (!common.hasIntl) { const URL = require('url').URL; const { test, assert_equals, assert_throws } = require('../common/wpt'); -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/historical.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/parallel/test-whatwg-url-origin.js b/test/parallel/test-whatwg-url-origin.js index 730087127a59b1..274de420bebbf3 100644 --- a/test/parallel/test-whatwg-url-origin.js +++ b/test/parallel/test-whatwg-url-origin.js @@ -13,7 +13,7 @@ const request = { response: require(path.join(common.fixturesDir, 'url-tests')) }; -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/url-origin.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/parallel/test-whatwg-url-searchparams-append.js b/test/parallel/test-whatwg-url-searchparams-append.js index 9d1c0eda49b053..fc9f5bd75d160b 100644 --- a/test/parallel/test-whatwg-url-searchparams-append.js +++ b/test/parallel/test-whatwg-url-searchparams-append.js @@ -5,7 +5,7 @@ const assert = require('assert'); const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals, assert_true } = require('../common/wpt'); -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-append.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/parallel/test-whatwg-url-searchparams-constructor.js b/test/parallel/test-whatwg-url-searchparams-constructor.js index 4737fa7c7bef1c..b6e720cc7fb04c 100644 --- a/test/parallel/test-whatwg-url-searchparams-constructor.js +++ b/test/parallel/test-whatwg-url-searchparams-constructor.js @@ -8,7 +8,7 @@ const { assert_false, assert_throws, assert_array_equals } = require('../common/wpt'); -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/54c3502d7b/url/urlsearchparams-constructor.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/parallel/test-whatwg-url-searchparams-delete.js b/test/parallel/test-whatwg-url-searchparams-delete.js index 66d59e71ddc9e4..6e733fd94466c4 100644 --- a/test/parallel/test-whatwg-url-searchparams-delete.js +++ b/test/parallel/test-whatwg-url-searchparams-delete.js @@ -6,7 +6,7 @@ const { URL, URLSearchParams } = require('url'); const { test, assert_equals, assert_true, assert_false } = require('../common/wpt'); -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-delete.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/parallel/test-whatwg-url-searchparams-foreach.js b/test/parallel/test-whatwg-url-searchparams-foreach.js index 0fd0b3c329459b..0147418ff21f07 100644 --- a/test/parallel/test-whatwg-url-searchparams-foreach.js +++ b/test/parallel/test-whatwg-url-searchparams-foreach.js @@ -6,7 +6,7 @@ const { URL, URLSearchParams } = require('url'); const { test, assert_array_equals, assert_unreached } = require('../common/wpt'); -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/a8b2b1e/url/urlsearchparams-foreach.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/parallel/test-whatwg-url-searchparams-get.js b/test/parallel/test-whatwg-url-searchparams-get.js index 0433b12a124e72..2e7d22c998bf02 100644 --- a/test/parallel/test-whatwg-url-searchparams-get.js +++ b/test/parallel/test-whatwg-url-searchparams-get.js @@ -5,7 +5,7 @@ const assert = require('assert'); const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals, assert_true } = require('../common/wpt'); -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-get.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/parallel/test-whatwg-url-searchparams-getall.js b/test/parallel/test-whatwg-url-searchparams-getall.js index 5623f2cecaef16..3a8bf347ff1f3f 100644 --- a/test/parallel/test-whatwg-url-searchparams-getall.js +++ b/test/parallel/test-whatwg-url-searchparams-getall.js @@ -6,7 +6,7 @@ const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals, assert_true, assert_array_equals } = require('../common/wpt'); -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-getall.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/parallel/test-whatwg-url-searchparams-has.js b/test/parallel/test-whatwg-url-searchparams-has.js index e33491a86cf59a..dcdf585dcdf76d 100644 --- a/test/parallel/test-whatwg-url-searchparams-has.js +++ b/test/parallel/test-whatwg-url-searchparams-has.js @@ -5,7 +5,7 @@ const assert = require('assert'); const URLSearchParams = require('url').URLSearchParams; const { test, assert_false, assert_true } = require('../common/wpt'); -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-has.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/parallel/test-whatwg-url-searchparams-set.js b/test/parallel/test-whatwg-url-searchparams-set.js index ba1e88450ede0b..46414ff23aba14 100644 --- a/test/parallel/test-whatwg-url-searchparams-set.js +++ b/test/parallel/test-whatwg-url-searchparams-set.js @@ -5,7 +5,7 @@ const assert = require('assert'); const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals, assert_true } = require('../common/wpt'); -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-set.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/parallel/test-whatwg-url-searchparams-sort.js b/test/parallel/test-whatwg-url-searchparams-sort.js index f2bf042d9cd2a4..712dbc5636d81b 100644 --- a/test/parallel/test-whatwg-url-searchparams-sort.js +++ b/test/parallel/test-whatwg-url-searchparams-sort.js @@ -4,7 +4,7 @@ require('../common'); const { URL, URLSearchParams } = require('url'); const { test, assert_array_equals } = require('../common/wpt'); -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/5903e00e77e85f8bcb21c73d1d7819fcd04763bd/url/urlsearchparams-sort.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/parallel/test-whatwg-url-searchparams-stringifier.js b/test/parallel/test-whatwg-url-searchparams-stringifier.js index 7d8f8e5bc794c4..e2f73d262e590b 100644 --- a/test/parallel/test-whatwg-url-searchparams-stringifier.js +++ b/test/parallel/test-whatwg-url-searchparams-stringifier.js @@ -5,7 +5,7 @@ const assert = require('assert'); const URLSearchParams = require('url').URLSearchParams; const { test, assert_equals } = require('../common/wpt'); -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-stringifier.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/parallel/test-whatwg-url-setters.js b/test/parallel/test-whatwg-url-setters.js index 40ba95ac4be49d..7e69bc4edce321 100644 --- a/test/parallel/test-whatwg-url-setters.js +++ b/test/parallel/test-whatwg-url-setters.js @@ -17,7 +17,7 @@ const request = { response: require(path.join(common.fixturesDir, 'url-setter-tests')) }; -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/8791bed/url/url-setters.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/parallel/test-whatwg-url-toascii.js b/test/parallel/test-whatwg-url-toascii.js index 2ee65712d1420a..5a34b0396495fa 100644 --- a/test/parallel/test-whatwg-url-toascii.js +++ b/test/parallel/test-whatwg-url-toascii.js @@ -13,7 +13,7 @@ const request = { response: require(path.join(common.fixturesDir, 'url-toascii')) }; -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/4839a0a804/url/toascii.window.js License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html diff --git a/test/parallel/test-whatwg-url-tojson.js b/test/parallel/test-whatwg-url-tojson.js index 6d4b5cbf7efd90..8e9a30c7e017e4 100644 --- a/test/parallel/test-whatwg-url-tojson.js +++ b/test/parallel/test-whatwg-url-tojson.js @@ -4,7 +4,7 @@ require('../common'); const URL = require('url').URL; const { test, assert_equals } = require('../common/wpt'); -/* The following tests are copied from WPT, modifications to them should be +/* The following tests are copied from WPT. Modifications to them should be upstreamed first. Refs: https://github.com/w3c/web-platform-tests/blob/02585db/url/url-tojson.html License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html