Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anchor links not anchoring (docs/latest) #53504

Closed
sparecycles opened this issue Jun 18, 2024 · 11 comments
Closed

anchor links not anchoring (docs/latest) #53504

sparecycles opened this issue Jun 18, 2024 · 11 comments
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs.

Comments

@sparecycles
Copy link

URL:

https://nodejs.org/docs/latest/api/os.html#osplatform

Browser Name:

Firefox

Browser Version:

127.0

Operating System:

OSX 14.4.1

How to reproduce the issue:

Visiting a doc link with a relatively deep anchor such as https://nodejs.org/docs/latest/api/os.html#osplatform

Expected

(page is scrolled to anchor)
image

Actual

(page is not scrolled to anchor)
image

Note

Also tried in Chrome.
image

And Edge:
image

@bmuenzenmeyer bmuenzenmeyer transferred this issue from nodejs/api-docs-tooling Jun 18, 2024
@avivkeller avivkeller added doc Issues and PRs related to the documentations. repro-exists labels Jun 18, 2024
@avivkeller
Copy link
Member

avivkeller commented Jun 18, 2024

I'm able to reproduce on multiple platforms. It has to do with the smooth scrolling. IIRC there might be an issue already open

@avivkeller avivkeller added the v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. label Jun 18, 2024
@avivkeller
Copy link
Member

Adding v22 as the v21 (w/o smooth scrolling) are not affected

@sparecycles
Copy link
Author

sparecycles commented Jun 19, 2024

In Chrome, V20 and V21 have os.platform() scrolled under the controls banner, but are basically on target.

image

But with Firefox, I'm still seeing the same bad behavior in V20 and V21 as V22. 😢

@sparecycles
Copy link
Author

#40099 might be related.

@avivkeller avivkeller removed the v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. label Jun 19, 2024
@avivkeller
Copy link
Member

#40099 might be related.

That issue refers to scroll jumping, but the same underlying feature might be the culprit

@tniessen
Copy link
Member

@ovflowd I assume this is a duplicate of #40099?

@ovflowd
Copy link
Member

ovflowd commented Jun 19, 2024

Adding v22 as the v21 (w/o smooth scrolling) are not affected

You mean v21 docs don't have this issue?

@ovflowd
Copy link
Member

ovflowd commented Jun 19, 2024

@ovflowd I assume this is a duplicate of #40099?

It might be, but not sure (feel like it is)

@avivkeller
Copy link
Member

You mean v21 docs don't have this issue?

I quickly checked the v21 docs on iOS safari, and they seemed fine, but I didn't do an extensive check.

@sparecycles
Copy link
Author

Ooh? Even the latest docs work in Safari, mostly.

Occasionally a direct load to the anchor leaves the view in the wrong position, but it instantly pops as soon as I start two-finger-scroll-dragging, (perhaps a safari rendering issue there)?

safari-scrolling.mp4

@ovflowd
Copy link
Member

ovflowd commented Jun 21, 2024

Duplicate of #40099

@ovflowd ovflowd marked this as a duplicate of #40099 Jun 21, 2024
@ovflowd ovflowd closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2024
@avivkeller avivkeller added duplicate Issues and PRs that are duplicates of other issues or PRs. and removed doc Issues and PRs related to the documentations. repro-exists labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs.
Projects
None yet
Development

No branches or pull requests

4 participants