From 91fb0cb6b0db95ec362e108da27bd1af53101185 Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Sat, 3 Jun 2017 13:22:57 -0700
Subject: [PATCH] test: refactor test-dgram-oob-buffer

* Change common.noop to common.mustNotCall() to verify callback is not
  invoked.
* Add destructuring assignment for clarity. Yeah, clarity. That's why.

PR-URL: https://github.com/nodejs/node/pull/13443
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
---
 test/parallel/test-dgram-oob-buffer.js | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/test/parallel/test-dgram-oob-buffer.js b/test/parallel/test-dgram-oob-buffer.js
index b49baa2e0d8dad..f93533479b2d93 100644
--- a/test/parallel/test-dgram-oob-buffer.js
+++ b/test/parallel/test-dgram-oob-buffer.js
@@ -10,15 +10,14 @@ const socket = dgram.createSocket('udp4');
 const buf = Buffer.from([1, 2, 3, 4]);
 const portGetter = dgram.createSocket('udp4')
   .bind(0, 'localhost', common.mustCall(() => {
-    const address = portGetter.address();
+    const { address, port } = portGetter.address();
     portGetter.close(common.mustCall(() => {
-      function ok() {}
-      socket.send(buf, 0, 0, address.port, address.address, ok);
-      socket.send(buf, 0, 4, address.port, address.address, ok);
-      socket.send(buf, 1, 3, address.port, address.address, ok);
-      socket.send(buf, 3, 1, address.port, address.address, ok);
+      socket.send(buf, 0, 0, port, address, common.mustNotCall());
+      socket.send(buf, 0, 4, port, address, common.mustNotCall());
+      socket.send(buf, 1, 3, port, address, common.mustNotCall());
+      socket.send(buf, 3, 1, port, address, common.mustNotCall());
       // Since length of zero means nothing, don't error despite OOB.
-      socket.send(buf, 4, 0, address.port, address.address, ok);
+      socket.send(buf, 4, 0, port, address, common.mustNotCall());
 
       socket.close();
     }));