From 6386f6222172267eef9426d4d73ea489e17158e7 Mon Sep 17 00:00:00 2001 From: Aayush Naik Date: Mon, 1 Feb 2016 16:04:14 +0530 Subject: [PATCH] test: remove unneeded bind() and related comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As mentioned in the comment of the changed file, "a libuv limitation makes it necessary to bind()". But, that is not the case in this test. The subsequent call to send() results in an implicit bind(). PR-URL: https://github.com/nodejs/node/pull/5023 Reviewed-By: Rich Trott Reviewed-By: Saúl Ibarra Corretgé --- test/internet/test-dgram-multicast-multi-process.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/test/internet/test-dgram-multicast-multi-process.js b/test/internet/test-dgram-multicast-multi-process.js index 5fa897fc6c35f3..69d7bbe3173787 100644 --- a/test/internet/test-dgram-multicast-multi-process.js +++ b/test/internet/test-dgram-multicast-multi-process.js @@ -132,10 +132,6 @@ if (process.argv[2] !== 'child') { } var sendSocket = dgram.createSocket('udp4'); - // FIXME: a libuv limitation makes it necessary to bind() - // before calling any of the set*() functions. The bind() - // call is what creates the actual socket. - sendSocket.bind(); // The socket is actually created async now. sendSocket.on('listening', function() {