From 0f2642ee36031adac63eb159822b7e2f7bfea033 Mon Sep 17 00:00:00 2001 From: DavidCai Date: Fri, 17 Mar 2017 14:13:58 +0800 Subject: [PATCH] errors: remove needless lazyAssert PR-URL: https://github.com/nodejs/node/pull/11891 Reviewed-By: Timothy Gu Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Daijiro Wachi --- lib/internal/errors.js | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/lib/internal/errors.js b/lib/internal/errors.js index 3cab1409422d6f..01e4e482cb0e69 100644 --- a/lib/internal/errors.js +++ b/lib/internal/errors.js @@ -6,16 +6,11 @@ // value statically and permanently identifies the error. While the error // message may change, the code should not. +const assert = require('assert'); const kCode = Symbol('code'); const messages = new Map(); -var assert, util; -function lazyAssert() { - if (!assert) - assert = require('assert'); - return assert; -} - +var util; function lazyUtil() { if (!util) util = require('util'); @@ -41,7 +36,6 @@ function makeNodeError(Base) { } function message(key, args) { - const assert = lazyAssert(); assert.strictEqual(typeof key, 'string'); const util = lazyUtil(); const msg = messages.get(key); @@ -60,7 +54,6 @@ function message(key, args) { // Utility function for registering the error codes. Only used here. Exported // *only* to allow for testing. function E(sym, val) { - const assert = lazyAssert(); assert(messages.has(sym) === false, `Error symbol: ${sym} was already used.`); messages.set(sym, typeof val === 'function' ? val : String(val)); }