-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V8 4.4 to remove indexed properties via external data #316
Comments
What about updating https://github.com/joyent/node/blob/v0.10.38/src/v8_typed_array.cc to conform with the final spec and creating wrapper functions that use this for old versions and v8's own implementation for new versions? |
@trevnorris What's the status of |
@kkoopa I don't have an implementation complete, but my preliminary research shows that we should be able to keep the current C++ Maintaining the same JS API has yet to be determined, but I don't believe that affects this. |
OK, that's good, I think. I don't care about the JS API. The question remains whether to backport typed arrays or not. Buffer should suffice, shouldn't it? That would mean addons neither set external array data nor use typed arrays. Does Buffer handle all those cases efficiently? |
@kkoopa Buffer does contain all the necessary APIs to create objects with a backing store of external memory. Either new, or from an existing allocation. So you shouldn't need to backport either the external array data or the array buffer APIs. |
That is very good. Less work for me. Then I'll close this issue, as there is nothing left to do. |
nodejs/node#1451
How to solve this in NAN?
The text was updated successfully, but these errors were encountered: