Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for using an external/system copy of Hedley #2651

Closed
2 tasks done
musicinmybrain opened this issue Feb 18, 2021 · 2 comments
Closed
2 tasks done

No support for using an external/system copy of Hedley #2651

musicinmybrain opened this issue Feb 18, 2021 · 2 comments

Comments

@musicinmybrain
Copy link
Contributor

What is the issue you have?

The project uses a bundled copy of Hedley, lightly forked with JSON_ prefixes and with each macro undefined at the end of the header.

It seems like it would be possible, albeit a little tedious, to support including a system copy of hedley.h, “wrapping” the unprefixed macros.

Most Linux distributions, such as Fedora, are opposed to bundling for various reasons. In order to package this software in Fedora, I am required to ask you to support using an external or system copy of Hedley, and to record any response.

Please describe the steps to reproduce the issue.

Look at the sources; see a bundled copy of Hedley.

Can you provide a small but working code example?

(not applicable)

What is the expected behavior?

(not applicable)

And what is the actual behavior instead?

(not applicable)

Which compiler and operating system are you using?

(not applicable)

Which version of the library did you use?

  • latest release version 3.9.1
  • the develop branch

If you experience a compilation error: can you compile and run the unit tests?

(not applicable)

@nlohmann
Copy link
Owner

I would not put effort into this myself, but PRs welcome.

@xvitaly
Copy link
Contributor

xvitaly commented Mar 27, 2021

Most Linux distributions, such as Fedora, are opposed to bundling for various reasons. In order to package this software in Fedora, I am required to ask you to support using an external or system copy of Hedley, and to record any response.

Fedora is okay with bundling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants