Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce repos size #1185

Closed
maddanio opened this issue Aug 3, 2018 · 1 comment · Fixed by #2081
Closed

reduce repos size #1185

maddanio opened this issue Aug 3, 2018 · 1 comment · Fixed by #2081
Assignees
@nlohmann
Labels
release item: 🔨 further change solution: duplicate the issue is a duplicate; refer to the linked issue instead solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.8.0

Comments

@maddanio
Copy link

maddanio commented Aug 3, 2018

When re-cloning this repo i keep noticing that it comes down as about 373MB. all this just to get a json parser/serializer. i would suggest outsourcing the test data (should it ever change?) and re-writing the history.
@nlohmann
Copy link
Owner

nlohmann commented Aug 3, 2018

Duplicate #96

@nlohmann nlohmann closed this as completed Aug 3, 2018
@nlohmann nlohmann added the solution: duplicate the issue is a duplicate; refer to the linked issue instead label Aug 3, 2018
@theodelrieu theodelrieu mentioned this issue Sep 20, 2018
Closed
4 tasks
@nlohmann nlohmann reopened this May 4, 2020
@nlohmann nlohmann linked a pull request May 4, 2020 that will close this issue
Use external test data #2081
Merged
@nlohmann nlohmann mentioned this issue May 4, 2020
Merged
@nlohmann nlohmann self-assigned this May 4, 2020
@nlohmann nlohmann added release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation labels May 4, 2020
@nlohmann nlohmann added this to the Release 3.8.0 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change solution: duplicate the issue is a duplicate; refer to the linked issue instead solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.8.0
Development

Successfully merging a pull request may close this issue.

Use external test data nlohmann/json
2 participants
@nlohmann @maddanio