Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Maintain first party Type GraphQL libraries with your fork #827

Closed
wSedlacek opened this issue Apr 29, 2020 · 2 comments
Closed

Comments

@wSedlacek
Copy link
Contributor

I'm submitting a...


[ ] Regression
[ ] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

typegraphql-prisma is not supported by @nestjs/graphql and there is no first party solution provided by @nestjs/graphql nor type-graphql for support of this library.

Expected behavior

I would expect typegraphql-prisma either be supported or @nestjs/graphql to provide an equal alternative.

Minimal reproduction of the problem with instructions

Attempt to use typegraphql-prisma in a project with @nestjs/graphql and @nestjs/graphql will not see the resolvers generated by typegraphql-prisma because a different ExternalContextCreator is used.

What is the motivation / use case for changing the behavior?

In NestJS v7 type-graphql was forked into @nestjs/graphql with many breaking changes including changing the names of exports and of course changing of the package itself. This is fine for use of type-graphql alone and in fact I even prefer the name of the import. The problem comes in with first party libraries that use type-graphql such as typegraphql-prisma

There has been a community fork to maintain a version of typegraphql-prisma for @nestjs/graphql (typegraphql-prisma-nestjs) however it is maintained by a single person and not updated as quickly as the upstream typegraphql-prisma and in my attempts to contribute to it I have found that many of the testing done for typegraphql-prisma is broken with the fork.

type-graphql itself has shown no intent of maintain support for the fork of @nestjs/graphql going as far as to make typegraphql-nestjs which completely circumvents @nestjs/graphql with a different API and no support for guards, interceptors, filters and pipes. I am sure you as much as me would have liked if type-graphql just worked with you to build a single API for nestjs however since they didn't I believe since @nestjs/graphql forked from type-graphql it is the responsibility of @nestjs/graphql to maintain support for any first party libraries of type-graphql that are still applicable such as typegraphql-prisma.

tl;dr Please maintain a fork of typegraphql-prisma for @nestjs/graphql if you are going to fork from type-graphql

Sources:

Environment


Nest version: 7.3.4
@kamilmysliwiec
Copy link
Member

it is the responsibility of @nestjs/graphql to maintain support for any first party libraries of type-graphql that are still applicable such as typegraphql-prisma

typegraphql-prisma was released almost at the same time as the new version of this package. I don't think that this means that we are now obliged to support every single feature & integration that type-graphql introduces on their side in the future.

There are no plans to integrate typegraphql-prisma at the moment.

@kamilmysliwiec
Copy link
Member

BTW this library is not "a fork". It's almost impossible for us to follow everything that will be added to type-graphql so expect that these libraries (and their APIs) will very likely diverse even more in the future.

@nestjs nestjs locked as resolved and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants