Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info: Fork of ncsms #230

Open
PhieF opened this issue Apr 16, 2020 · 8 comments
Open

Info: Fork of ncsms #230

PhieF opened this issue Apr 16, 2020 · 8 comments

Comments

@PhieF
Copy link

PhieF commented Apr 16, 2020

Hi,

with the /e/ team we've forked ncsms both the app and the cloud app to suit our needs
One feature that might interest you is the send sms from web ui, as well as filter conversation and start a conversation with a contact

you can find our code here:
https://gitlab.e.foundation/e/apps/ncsms-android
https://gitlab.e.foundation/e/apps/ncsmsgo/
https://gitlab.e.foundation/e/infra/selfhost/nextcloud-apps/esms

please contact me if you have any questions or need help to understand my messy commits,
If you want the feature I can perhaps find some free time to make a pull request

Thanks a lot for your work !

@nerzhul
Copy link
Owner

nerzhul commented Apr 17, 2020

why did you forked it instead of contributing ?

@PhieF
Copy link
Author

PhieF commented Apr 17, 2020

I guess different reasons:
We have specific needs, integration with our account manager, the modified import feature that only works with our sms app, as well as other things you might not find useful but we needed
(features or design changes)
I makes it easier to get it running more quickly. The fork is only for the /e/ operating system
When I'll have time I will try to make specific merge request by features

@e-alfred
Copy link
Contributor

e-alfred commented Apr 19, 2020

@PhieF Can you contribute to the Android App and the Nextcloud app? Some of your changes might be of interest for Upstream and therefore our Nextcloud users as well especially the SMS sending feature.

Personally I like the idea of /e/, but contributing back and making Nextcloud better as a whole is surely a good way to archive the common goals of both projects.

@PhieF
Copy link
Author

PhieF commented Apr 20, 2020

I totally agree with this, that's why I'd like to know what would interest you the most :) I will start with the send sms feature, and the filter + start conversation

@e-alfred
Copy link
Contributor

e-alfred commented Apr 24, 2020

@PhieF Aweseome, just let them roll in. 👍 I think any feature/bug fix that isn't completely /e/-specific would help us and the users. It would be great to push your changes to upstream regularly which would help everybody I think.

@e-alfred
Copy link
Contributor

@PhieF anything new about pushing your changes to upstream? We would really like to make these features available to all of our Nextcloud users.

@Thovi98
Copy link

Thovi98 commented Nov 9, 2020

@PhieF If you have any free time, I would love to see your features merged here !

@azmeuk
Copy link

azmeuk commented Feb 25, 2022

I totally agree with this, that's why I'd like to know what would interest you the most :) I will start with the send sms feature, and the filter + start conversation

Gentle ping @PhieF. Is there any news on that front?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants