Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autofit in auto-profile doesn't work for first item #9661

Closed
escapezn opened this issue Dec 31, 2021 · 5 comments
Closed

autofit in auto-profile doesn't work for first item #9661

escapezn opened this issue Dec 31, 2021 · 5 comments
Labels

Comments

@escapezn
Copy link

escapezn commented Dec 31, 2021

Important Information

Provide following Information:

  • mpv version 0.34
  • Windows Version windows 10 1909
  • Source of the mpv binary
  • If known which version of mpv introduced the problem
  • Possible screenshot or video of visual glitches

If you're not using git master or the latest release, update.
Releases are listed here: https://github.com/mpv-player/mpv/releases

Reproduction steps

I'd like to keep mpv window size roughly constant when playing music with albumart, so a section of profile added.

[audio]
profile-cond=not vid or get("current-tracks/video/albumart")
loop-playlist = inf
autofit-larger = 24%
autofit-smaller = 24%
autofit = 24%
# profile-restore = copy-equal

Expected behavior

The width of mpv window is fixed at 24% of my screen as long as playing music.

Actual behavior

Mpv window doesn't resize to 24% on the first music loaded, although this profile has indeed been applyed according to console. Since the second mpv normally adjusts its size.

And another question is that if profile-restore were configured, no matter as copy or copy-equal, autofit here will never take effect. Is this expected or not?

Log file

log.txt

Sample files

@escapezn
Copy link
Author

escapezn commented Dec 31, 2021

It's weird that autofit has no effect for some audio files at all.
log1.txt

@guidocella
Copy link
Contributor

Duplicate of #8379. Runtime changes of geometry and autofit have only been implemented on X11 and Wayland so far.

@escapezn
Copy link
Author

Thank you for replying. Also I understand why for some files it works while for others not. #8379 (comment)

@Dudemanguy
Copy link
Member

Closing since it is a duplicate as noted. The fix would be to implement runtime geometry/autofit on Windows.

@escapezn
Copy link
Author

#13626 solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants