Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need Ord and PartialOrd for security version types #374

Closed
2 tasks
Tracked by #3428
, #3309
...
nick-mobilecoin opened this issue Jul 20, 2023 · 0 comments · Fixed by #450
Closed
2 tasks
Tracked by #3428
, #3309
...

Need Ord and PartialOrd for security version types #374

nick-mobilecoin opened this issue Jul 20, 2023 · 0 comments · Fixed by #450
Labels
needs-triage

Comments

@nick-mobilecoin
Copy link
Collaborator

nick-mobilecoin commented Jul 20, 2023 •
edited
Loading

security version numbers (SVN) are compared AsRef instead of directly. As such we should derive/implement the ord logic on these types

  • IsvSVn
  • ConfigSvn
This was referenced Jul 20, 2023
Open
Merged
@nick-mobilecoin nick-mobilecoin changed the title Need Ord and PartialOrd for IsvSvn Need Ord and PartialOrd for security version types Jul 21, 2023
@nick-mobilecoin nick-mobilecoin mentioned this issue Jul 25, 2023
Open
@nick-mobilecoin nick-mobilecoin linked a pull request Dec 4, 2023 that will close this issue
Add Ord and PartialOrd to ConfigSvn and IsvSvn #450
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Ord and PartialOrd to ConfigSvn and IsvSvn mobilecoinfoundation/sgx
1 participant
@nick-mobilecoin