Editing plan and changing PV from Copy to Move method breaks migrations

[jmontleon]

I created a plan initially set to copy two PV's. Realizing I had failed to change it to Move I went back and edited the plan.

I ended up with a plan that looked like below.

In particular this looks like the UI is not removing the copyMethod when the action is changed, so there's probably a UI issue here. It seems like a user could do this too so there should probably be a validation to prevent the plan from proceeding if the conflicting options are set.

    selection:
      action: move
      copyMethod: filesystem

At this point the plan got stuck at StageRestoreCreated.

# Please edit the object below. Lines beginning with a '#' will be ignored,
# and an empty file will abort the edit. If an error occurs while saving this file will be
# reopened with the relevant failures.
#
apiVersion: migration.openshift.io/v1alpha1
kind: MigPlan
metadata:
  annotations:
    openshift.io/touch: 6c54ee61-99e4-11ea-920a-0a580a83001d
  creationTimestamp: "2020-05-19T14:37:47Z"
  generation: 17
  name: mediawiki
  namespace: openshift-migration
  resourceVersion: "1172282"
  selfLink: /apis/migration.openshift.io/v1alpha1/namespaces/openshift-migration/migplans/mediawiki
  uid: d24062eb-8b07-44bc-997c-f885aa6913f1
spec:
  destMigClusterRef:
    name: host
    namespace: openshift-migration
  hooks:
  - executionNamespace: openshift-migration
    phase: PostRestore
    reference:
      name: mediawiki-repair-vglcg
      namespace: openshift-migration
    serviceAccount: migration-controller
  migStorageRef:
    name: default
    namespace: openshift-migration
  namespaces:
  - mediawiki
  persistentVolumes:
  - capacity: 1000Gi
    name: pv2
    pvc:
      accessModes:
      - ReadWriteOnce
      name: mariadb
      namespace: mediawiki
    selection:
      action: move
      copyMethod: filesystem
    supported:
      actions:
      - copy
      - move
      copyMethods:
      - filesystem
      - snapshot
  - capacity: 1000Gi
    name: pv6
    pvc:
      accessModes:
      - ReadWriteOnce
      name: mediawiki
      namespace: mediawiki
    selection:
      action: move
      copyMethod: filesystem
    supported:
      actions:
      - copy
      - move
      copyMethods:
      - filesystem
      - snapshot
  srcMigClusterRef:
    name: ocp311
    namespace: openshift-migration
status:
  conditions:
  - category: Required
    lastTransitionTime: "2020-05-19T14:37:55Z"
    message: The `persistentVolumes` list has been updated with discovered PVs.
    reason: Done
    status: "True"
    type: PvsDiscovered
  - category: Required
    lastTransitionTime: "2020-05-19T14:37:58Z"
    message: The storage resources have been created.
    status: "True"
    type: StorageEnsured
  - category: Required
    lastTransitionTime: "2020-05-19T14:38:02Z"
    message: The migration registry resources have been created.
    status: "True"
    type: RegistriesEnsured
  - category: Required
    lastTransitionTime: "2020-05-19T14:38:02Z"
    message: The migration plan is ready.
    status: "True"
    type: Ready
  - category: Advisory
    lastTransitionTime: "2020-05-19T15:13:06Z"
    message: Limited validation; PV discovery and resource reconciliation suspended.
    status: "True"
    type: Suspended
  observedDigest: ccc6a4830c8ace4d92af7facc1af952b36a10109992aa6d56fcf7cac428dde1e

[sseago]

CopyMethod should be ignored for Move, so if leaving it there breaks things, that's a bug.

[djwhatle]

Sounds like a UI bug, closing in favor of mig-ui issue migtools/mig-ui#1045