Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug doesn't show completion #8260

Closed
jrieken opened this issue Jun 28, 2016 · 2 comments
Closed

debug doesn't show completion #8260

jrieken opened this issue Jun 28, 2016 · 2 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@jrieken
Copy link
Member

jrieken commented Jun 28, 2016

  • have the snippet below (npm i github)
  • run on the console node app.js it terminates quickly
  • run the same with the generated launch config and the stop/resume control keep showing

jun-28-2016 11-04-39

'use strict';

const GitHubApi = require("github");
const github = new GitHubApi({
    // debug: true 
});

github.issues.getForRepo({
    user: 'Microsoft',
    repo: 'vscode',
    milestone: 20,
    labels: 'testplan-item'
}, function (err, res) {
    for (let item of res) {
        console.log(`- [${item.state === 'open' ? ' ' : 'x'}] ${item.title}, #${item.number}`)
    }
});
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority debug Debug viewlet, configurations, breakpoints, adapter issues labels Jun 28, 2016
@isidorn
Copy link
Contributor

isidorn commented Jun 28, 2016

I think this is designed node behavior that it does not exit in this case. Forwarding to @weinand to decide.

@isidorn isidorn assigned weinand and unassigned isidorn Jun 28, 2016
@weinand
Copy link
Contributor

weinand commented Jun 28, 2016

This is a node bug: nodejs/node#1788
You will see the same behaviour with node-inspector.

@weinand weinand closed this as completed Jun 28, 2016
@isidorn isidorn added upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Jul 1, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants