Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux package names #4398

Closed
chrisdias opened this issue Mar 18, 2016 · 1 comment
Closed

linux package names #4398

chrisdias opened this issue Mar 18, 2016 · 1 comment
Assignees

Comments

@chrisdias
Copy link
Member

the linux package file names are:

vscode-i386.deb
vscode-i386.rpm

the pattern we have for the linux zips is this:
vscode-linux-ia32-insider.zip
vscode-linux-x64-insider.zip

I would expect then the packages to have names like this:
vscode-linux-deb-ia32-insider.deb
vscode-linux-rpm-ia32-insider.rpm

@chrisdias chrisdias added this to the April 2016 milestone Mar 18, 2016
@Tyriar
Copy link
Member

Tyriar commented Mar 18, 2016

The file names are named using what architecture they're built as. For deb that is i386/amd64 and for rpm that is i386/x86_64, ia32 and x64 aren't valid architectures for deb/rpm files. It's best practice to keep these in the file names for clarity0. I've been toying with the idea that we don't even need to provide the zip at all since deb and rpm files can just be extracted much like zips, only the package files contain addition files like the launcher which is becoming more and more essential. Reopen if there is still an issue.

@Tyriar Tyriar closed this as completed Mar 18, 2016
@Tyriar Tyriar removed this from the April 2016 milestone Apr 20, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants