Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leakage when refreshing explorer #4123

Closed
jrieken opened this issue Mar 14, 2016 · 2 comments
Closed

Leakage when refreshing explorer #4123

jrieken opened this issue Mar 14, 2016 · 2 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
March 2016

Comments

@jrieken
Copy link
Member

jrieken commented Mar 14, 2016

  • open a workspace with ~40 files/folders in the root dir
  • refresh the explorer
  • take a heap snapshot
  • refresh the explorer 10 times
  • take another heap snapshot, heap grew by 0.1MB
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Mar 15, 2016
@bpasero bpasero added this to the March 2016 milestone Mar 15, 2016
@bpasero
Copy link
Member

bpasero commented Mar 16, 2016

@jrieken did you get anything more concrete out of the heap snapshot than those basic types here?

image

@bpasero bpasero changed the title little leakage when refreshing explorer Leakage when refreshing explorer Mar 16, 2016
@bpasero
Copy link
Member

bpasero commented Mar 17, 2016

See attached heap allocations over time, picking a span between multiple refreshes, I do not see information about leaks:

untitled

@bpasero bpasero closed this as completed Mar 17, 2016
@bpasero bpasero assigned jrieken and unassigned bpasero Mar 17, 2016
@bpasero bpasero mentioned this issue Mar 17, 2016
Closed
@jrieken jrieken added the verified Verification succeeded label Mar 21, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
March 2016
Development

No branches or pull requests
2 participants
@bpasero @jrieken