Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable default color decorators by default #233083

Closed
aiday-mar opened this issue Nov 5, 2024 · 4 comments · Fixed by #233095
Closed

Enable default color decorators by default #233083

aiday-mar opened this issue Nov 5, 2024 · 4 comments · Fixed by #233095
Assignees
Labels
editor-color-picker Editor color picker widget issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@aiday-mar
Copy link
Contributor

This feature request is about this month's iteration plan item which is to enable default color decorators by default. The default color decorators are provided by the default color decorator.

@aiday-mar aiday-mar added the editor-color-picker Editor color picker widget issues label Nov 5, 2024
@aiday-mar aiday-mar self-assigned this Nov 5, 2024
@aiday-mar aiday-mar added the feature-request Request for new features or functionality label Nov 5, 2024
@aiday-mar
Copy link
Contributor Author

The default color decorators use the default color provider which resolves:

#rgb to #rrggbb
#rgba to #rrggbbaa

In this way it is possible to have 3, 4, 6 and 8 length hex codes. It may be strange to see color decorators next to length 3 and 4 hex codes, so we could disable this, and show color decorators for length 6 and length 8 hex codes.

@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Nov 5, 2024
@vs-code-engineering vs-code-engineering bot added this to the November 2024 milestone Nov 5, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 6, 2024
@aiday-mar aiday-mar added the verification-needed Verification of issue is requested label Dec 3, 2024
@aiday-mar
Copy link
Contributor Author

To verify:

  • Write a hex value of length 6 or 8 in the editor and check that a default color decorator appears in front of the color

@alexr00
Copy link
Member

alexr00 commented Dec 3, 2024

@aiday-mar what language does the editor need to be for this to work? I tried doing something like this with typescript but I didn't get a decoration:

		const temp = '#00ffaa';

@alexr00 alexr00 added the verification-steps-needed Steps to verify are needed for verification label Dec 3, 2024
@aiday-mar
Copy link
Contributor Author

Hi @alexr00 yes thank you for the ping. I forgot to mention that the hex value should not be surrounded by other non whitespace characters. In your example, the hex value has an apostrophe in front of the hashtag.

@alexr00 alexr00 added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Dec 3, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-color-picker Editor color picker widget issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants