Test and iterate on TS expandable hover apis

[mjbvz]

To try it:

• Build this TS branch and set it as your workspace TS version: Proposed expandable hover API TypeScript#59940
• In VS Code "typescript.experimental.expandableHover": true

Let's test out TS's current implementation of expandable hovers. The main question is if the UI is good enough as-is, or if it turns out we need something different, which may require API changes

[aiday-mar]

Tagging @gabritto about the following

I followed the steps in order to use the TypeScript compiler from the branch. Some feedback I have:

In the vscode repo on line 202 of the file contentHoverController.ts, hover on this._contentWidget, this shows an expandable hover. Expand it, this creates a big hover with the expanded type of the content widget. Aside from the fact that the hover is really long, which I am not sure can be avoided, I noticed several things:

• The hover content is cut off, with an ellipsis at the end. Either the editor hover cuts off content or TypeScript truncated the editor text. In this case I would have liked to see the full type.
• Curiously there is incorrect tokenization/colorization of the code in the hover. I am not sure if this is somehow related to the TreeSitter work that was recently done or if this has always been like this.
• As we previously discussed, it would be good to have clickable links that expand the hover instead of expanding everything at the same time. Expanding everything makes the hover unnecessarily long and hard to navigate.

Screen.Recording.2024-10-31.at.15.47.58.mov

I think it would be good generally to change the API so that we allow linkification of markdown text for the purpose of expansion. Perhaps in the coming iterations, I can develop this, if there is sufficient need for this to be put into the iteration plan.

cc @alexdima

[gabritto]

Tagging @gabritto about the following

I followed the steps in order to use the TypeScript compiler from the branch. Some feedback I have:

In the vscode repo on line 202 of the file contentHoverController.ts, hover on this._contentWidget, this shows an expandable hover. Expand it, this creates a big hover with the expanded type of the content widget. Aside from the fact that the hover is really long, which I am not sure can be avoided, I noticed several things:

• The hover content is cut off, with ellipsis at the end. Either the editor hover cuts off content or TypeScript truncated the editor text. In this case I would have liked to see the full type.
• Curiously there is incorrect tokenization/colorization of the code in the hover. I am not sure if this is somehow related to the TreeSitter work that was recently done or if this has always been like this.
• As we previously discussed, it would be good to have clickable links that expand the hover instead of expanding everything at the same time. Expanding everything makes the hover unnecessarily long and hard to navigate.

Screen.Recording.2024-10-31.at.15.47.58.mov
I think it would be good generally to change the API so that we allow linkification of markdown text for the purpose of expansion. Perhaps in the coming iterations, I can develop this, if there is sufficient need for this to be put into the iteration plan.

cc @alexdima

Thanks for the feedback. I removed truncation of the hover content on the TSServer side when expandable hovers are requested, so I think that's happening on the vscode side.

[aiday-mar]

I see thanks for letting me know, I'll have a look to remove truncation of hovers. I will discuss this issue with my manager to see if we should place the linkification of markdown text into the iteration plan and work on it.

I suppose also we could do a test pass on this perhaps during release week to get feedback about this.

[aiday-mar]

Hi I discussed this with my manager. Could we merge and publish the TypeScript branch work to production so we can self-host easily on the work in VS Code?

[DanielRosenwasser]

Hey @aiday-mar, the PR was merged yesterday afternoon. You all should be able to pick it up in the current nightly (5.8.0-dev.20241106), but let me know if there are any issues with that.

[aiday-mar]

Hi @DanielRosenwasser thanks for letting me know, I will upgrade the TypeScript version

[aiday-mar]

Here is the list of feedback I received. I will update this list as more feedback is received:

• Make the +/- button stick to the bottom of the hover part in such a way that it is always visible. The +/- buttons would scroll with the scrollbar and would clip to the top or the bottom of their respective hover parts.
• Increase +/- button size