Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize notebook mime types in error messages #170992

Closed
mjbvz opened this issue Jan 10, 2023 · 0 comments
Closed

Sanitize notebook mime types in error messages #170992

mjbvz opened this issue Jan 10, 2023 · 0 comments
Labels
security verified Verification succeeded

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 10, 2023

VS Code - Remote Code Execution Vulnerability

A remote code execution vulnerability exists in VS Code 1.74.2 and earlier versions where opening a maliciously crafted notebook allows script execution inside of notebook's iframe. This works in untrusted workspaces and only requires that the user open the notebook. The executed script is run inside of an isolated iframe, however it is possible an attacker could combine this with additional exploits to break out of the iframe

Patches

The fix is available starting with VS Code 1.74.3. The fix (5b8361b) mitigates this attack by more safely constructing html instead

Workarounds

Do not open notebooks from untrusted sources

References

@mjbvz mjbvz added this to the November 2022 Recovery 3 milestone Jan 10, 2023
@mjbvz mjbvz changed the title Sanitize notebook mime types Sanitize notebook mime types in error messages Jan 10, 2023
@mjbvz mjbvz closed this as completed Jan 10, 2023
@mjbvz mjbvz added verified Verification succeeded security labels Jan 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
security verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants
@mjbvz and others