Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Add an option to allow Alt+F5 to jump to the next --word-diff instead of the whole line #166472

Open
jooyoungseo opened this issue Nov 16, 2022 · 12 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues diff-editor Diff editor issues feature-request Request for new features or functionality
Milestone

Comments

@jooyoungseo
Copy link

CC @isidorn and @meganrogge

Although Alt+F5 and F7 provide accessible diff navigation for screen reader users, it is still challenging to identify exact changes when focused on the whole line.

Could you please consider adding a setting option to allow Alt+F5 to land in --word-diff instead of the whole line so that screen reader users can more easily identify modified locations?

System Info

Version: 1.74.0-insider (system setup)
Commit: edccbd1
Date: 2022-11-16T05:24:12.776Z
Electron: 19.1.3
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: Yes

@vscodenpa vscodenpa added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Nov 16, 2022
@meganrogge
Copy link
Contributor

Is your thought that for a line with 3 words changed, pressing Alt+f5 would place the cursor at the start of word 1, start of word 2, start of word 3, start of word 1, and so on?

@meganrogge meganrogge added the info-needed Issue requires more information from poster label Nov 16, 2022
@jooyoungseo
Copy link
Author

@meganrogge -- Exactly! As you may understand, good accessibility is minimizing cognitive load burden. That kind of navigation could improve blind programmers' productivity because we could save more time and cognitive effort and precisely get focused on exact changes upon the key press. Otherwise, we have to read through and compare between all the before and after diffs line by line, including something remaining the same.

@jooyoungseo
Copy link
Author

For example, personally I have found the following options so useful when diffing changes in terminal:

# Display word-based changes
git diff --word-diff

# character-based changes
git diff --word-diff-regex="."

The level of customization of Alt+F5 landing point would also contribute to general usability of VSCode for sighted users as well.

However, I think blind people are more disfranchised from the benefit of git diff because line-by-line diff takes much more time for us than people imagine since we cannot take a glance.

@meganrogge meganrogge added feature-request Request for new features or functionality and removed info-needed Issue requires more information from poster labels Dec 5, 2022
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Dec 5, 2022
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@meganrogge meganrogge added the diff-editor Diff editor issues label Dec 6, 2022
@vscodenpa
Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2023
@meganrogge meganrogge reopened this Feb 5, 2023
@jooyoungseo
Copy link
Author

Related issue: #103285 as well as this Stack Overflow question.

@vscodenpa
Copy link

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2023
@meganrogge meganrogge reopened this Feb 6, 2023
@vscodenpa
Copy link

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2023
@meganrogge meganrogge modified the milestones: Backlog Candidates, Backlog Feb 7, 2023
@meganrogge meganrogge reopened this Feb 7, 2023
@meganrogge
Copy link
Contributor

@hediet I discussed your thought about how we can present word diffs in an accessible way and @jooyoungseo mentioned this issue, which would fix that.

@meganrogge
Copy link
Contributor

@hediet, JooYoung suggested that once we have implemented this, it would be great if on show of the hover, we could indicate if the change was an insertion, deletion, or modification. Would that be possible?

@hediet
Copy link
Member

hediet commented Jan 31, 2024

it would be great if on show of the hover, we could indicate if the change was an insertion, deletion, or modification. Would that be possible?

I think it would be possible! But is certainly some work that requires planning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues diff-editor Diff editor issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants