Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode code base - migrate to consuming typings from npm as supported by TS 2.0 #14043

Closed
egamma opened this issue Oct 20, 2016 · 6 comments
Closed
Assignees
Labels
debt Code quality issues

Comments

@egamma
Copy link
Member

egamma commented Oct 20, 2016

The code base still includes a typings folder.

Now, that we are on 2.0 we should consider migrating to consume typings through npm.

@egamma egamma added the debt Code quality issues label Oct 20, 2016
@dbaeumer dbaeumer added this to the November 2016 milestone Oct 24, 2016
@dbaeumer
Copy link
Member

Blocked by jrieken/gulp-tsb#51

@dbaeumer dbaeumer modified the milestones: January 2017, November 2016 Dec 6, 2016
@dbaeumer
Copy link
Member

dbaeumer commented Dec 6, 2016

Did not make it for November.

@egamma egamma mentioned this issue Dec 20, 2016
56 tasks
@dbaeumer dbaeumer modified the milestones: February 2017, January 2017 Jan 23, 2017
@dbaeumer dbaeumer modified the milestones: March 2017, February 2017 Feb 17, 2017
@dbaeumer dbaeumer modified the milestones: On Deck, March 2017 Mar 24, 2017
@dbaeumer
Copy link
Member

Some improvements happened but we still have quite some code referring to d.ts files in the typings folder.

@gulshan
Copy link

gulshan commented Jun 19, 2019

Is it still relevant?

@dbaeumer
Copy link
Member

Yes, there is still a typings folder mainly because we customize some of the typings. Need to investigate which once we need to keep.

@dbaeumer
Copy link
Member

I am closing the issue. I looked over the typings folder and there are now quite some new typings because we forked existing npm modules. For the once were it looked reasonable we have them in the package.json now (see https://github.com/Microsoft/vscode/blob/master/package.json#L62)

@dbaeumer dbaeumer removed this from the On Deck milestone Oct 15, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

3 participants