machine scope settings defined in user settings need to be ignored in the remote context

[egamma]

When a machine scoped setting is defined in a user setting, then it needs to be ignored in a remote context.

[sandy081]

@roblourens I fixed it in the model and schema, can you please make sure the user settings in remote window does not show machine settings?

[roblourens]

Yeah I did that a long time ago

[egamma]

@roblourens @sandy081 can the issue be closed now?

[sandy081]

@roblourens Not sure if it is fixed in UI. I still see machine settings in user settings in remote window

[roblourens]

Oh I thought this was about app-scoped settings in the Remote tab.

[roblourens]

Wait are we sure we want to prevent this? It still seems like a valid way to configure things? Maybe I connect to lots of remotes that are configured the same way and I don't want to configure each remote independently?

If I set the setting in user settings JSON will it still be respected for the remote?

[sandy081]

Machine settings scoped to a machine and by definition they vary per machine. So I think it makes sense to not to respect local machine settings configured in user settings in a remote window.

[roblourens]

It seems like they likely vary per machine, but they don't have to, and if they don't, we are removing a potentially valid use case, for what benefit?

[roblourens]

Anyway I'll fix this and we can always tweak it later

[sandy081]

I would rather more concerned about if they vary which will break.

@roblourens Instead of hiding machine settings in the user settings, is it possible to show them and add a warning icon? This will help users to understand about it?

[roblourens]

Sure but I think we should do the same for all settings that are invalid for the scope.

[isidorn]

I verified that the git.path does not show up both in the .json file and in the settings ux -> verified