Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test UI changes for the Python interpreter selection quickpick #17070

Closed
3 tasks done
kimadeline opened this issue Aug 23, 2021 · 8 comments
Closed
3 tasks done

Test UI changes for the Python interpreter selection quickpick #17070

kimadeline opened this issue Aug 23, 2021 · 8 comments

Comments

@kimadeline
Copy link

kimadeline commented Aug 23, 2021

Refs: #16971

Complexity: 4

Create Issue


Requirements:

  1. Make sure you have "python.experiments.optInto": ["All"], in your user settings. If not, add it and reload.
  2. Create 2 workspaces with Python files in it, and create a virtual environment in one of them (python -m venv .venv). Let's name them with and without
  3. Python 3 available on your machine
  4. Use the following build of the Python extension: https://github.com/microsoft/vscode-python/suites/3575138020/artifacts/85925936

🔍 Please report anything you find unintuitive, redundant, or missing.

Scenario 1: python .defaultInterpreterPath not set, no virtual environment

  1. Make sure that the python.defaultIntepreterPath entries in your user and workspace settings are at their default value python
  2. Open the without workspace, wait for the extension to load, and click on the interpreter in the status bar on the bottom left:
    image
  3. Make sure that the interpreter that is currently highlighted in the quickpick is the same as the one that is currently selected (same path being shown in Current: ....), that the entry label starts with star ⭐️ , and that its description says "Recommended"
  4. Make sure that there is no "Use Python from python.defaultInterpreterPath setting" entry

Scenario 2: python.defaultInterpreterPath set, no virtual environment

  1. Set one of the python.defaultIntepreterPath entries in your user and workspace settings to a valid Python interpreter path that is not python (for example /usr/local/bin/python3)
  2. Open the without workspace, wait for the extension to load, and click on the interpreter in the status bar on the bottom left
  3. Make sure that the interpreter currently selected has the same path as what's in python.defaultInterpreterPath
  4. Make sure there is a "Use Python from python.defaultInterpreterPath setting" entry with the same path, that this entry is highlighted, and that it's the second on the list starting from the top (right below "Enter interpreter path...")

Scenario 3: python.defaultInterpreterPath not set, with virtual environment

  1. Make sure the python.defaultIntepreterPath entry in your user and workspace settings are at their default value python
  2. Open the with workspace, wait for the extension to load
  3. Make sure that the interpreter in the status bar on the bottom left is the .venv virtual environment you created above, and then click it
  4. Make sure that the interpreter that is currently highlighted in the quickpick is the .venv one, that the entry should be the second one from the top, that its label starts with a star ⭐️, and that its description says "Recommended"
  5. Make sure that there are no duplicate entries with the same interpreter path
  6. Make sure that there is no "Use Python from python.defaultInterpreterPath setting" entry

Scenario 4: python.defaultInterpreterPath set, with virtual environment

  1. Set one of the python.defaultIntepreterPath entries in your user and workspace settings to a valid Python interpreter path that is not python (for example /usr/local/bin/python3)
  2. Open the with workspace, wait for the extension to load, and click on the interpreter in the status bar on the bottom left
  3. Make sure that the interpreter currently selected has the same path as what's in python.defaultInterpreterPath
  4. Make sure there is a "Use Python from python.defaultInterpreterPath setting" entry with the same path, that this entry is highlighted, and that it's the second on the list starting from the top (right below "Enter interpreter path...")
  5. Make sure that the third entry is the .venv environment, that its label starts with a star ⭐️, and that its description says "Recommended"
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Aug 23, 2021
@kimadeline kimadeline removed the triage-needed Needs assignment to the proper sub-team label Aug 23, 2021
@kimadeline kimadeline added this to the August 2021 milestone Aug 23, 2021
@bpasero
Copy link
Member

bpasero commented Aug 24, 2021

I am not feeling very comfortable changing my main dev machine to Python 3, given I have only 2 installed and I don't want to mess with it (as it is needed to yarn VSCode for dev purposes).

What is the recommendation to get an isolated environment on macOS in this case? I found pyenv but wonder if that could mess with my main Python too.

This was referenced Aug 24, 2021
@bpasero
Copy link
Member

bpasero commented Aug 24, 2021

Nevermind, I got help on that.

I found a few issues that make me wonder whether I tested the right version, I installed [email protected] and set to use insiders "Daily".

@bpasero bpasero removed their assignment Aug 24, 2021
@kimadeline
Copy link
Author

kimadeline commented Aug 24, 2021

Hi @bpasero, would you mind testing again with a release build? This one: https://github.com/microsoft/vscode-python/suites/3575212483/artifacts/85927474

Let me update the test plan with the build, sorry about that.

After double-checking it it might be outdated, will investigate our builds first.

Double-checked, this build should work: https://github.com/microsoft/vscode-python/suites/3575138020/artifacts/85925936
Updating the test plan.

@sandy081
Copy link
Member

@bpasero Not sure if your un-assignment is intended as the checkbox is not checked in the description. Hence assigning you again. Please unassign and check if you are done with testing here.

@eamodio
Copy link

eamodio commented Aug 25, 2021

@kimadeline For me all scenarios failed except for #1. FYI, I'm in Windows 11 on ARM64 if that matters.

@eamodio eamodio closed this as completed Aug 25, 2021
@eamodio eamodio removed their assignment Aug 25, 2021
@kimadeline
Copy link
Author

@eamodio which version of the extension were you using? Could you set the python.logging.level user setting to "Debug" and copy the content of the "Python" output channel for each failing scenario?

I'm in Windows 11 on ARM64 if that matters

Hmmm it shouldn't, but you never know 🤔

@eamodio
Copy link

eamodio commented Aug 25, 2021

@kimadeline I updated the issues I filed with screenshots and logs. Although Scenario 3 started working and can no longer reproduce.

@bpasero
Copy link
Member

bpasero commented Aug 26, 2021

It turns out none of my testing was for the right latest version. For the future it would be helpful to indicate exactly which build to use.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants