Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Jedi to use LSP instead of internal registration #1401

Closed
rchiodo opened this issue Aug 19, 2020 · 9 comments
Closed

Move Jedi to use LSP instead of internal registration #1401

rchiodo opened this issue Aug 19, 2020 · 9 comments
Assignees

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Aug 19, 2020

This is the second step in making a working intellisense engine for notebooks. Could be based on this:
https://github.com/pappasam/jedi-language-server

@IanMatthewHuff
Copy link
Member

@rchiodo What can I do to validate this?

@rchiodo
Copy link
Contributor Author

rchiodo commented Oct 8, 2020

Set your language server to Jedi and then set this experiment to on:

    "python.experiments.optInto": [
        "jediLSP",
    ],

Reload VS code and then attempt intellisense in a normal python file.

@IanMatthewHuff
Copy link
Member

Doesn't seem to be working for me. I get this message and no intellisense:

image.png

@rchiodo
Copy link
Contributor Author

rchiodo commented Oct 8, 2020

Are you doing this with the vsix bits or with your debug bits? You need to install the server manually if you're using debug bits

@IanMatthewHuff
Copy link
Member

I was using debug bits. I'll just swap over to a VSIX seems easier than installing a server manually.

@rchiodo
Copy link
Contributor Author

rchiodo commented Oct 8, 2020

You run this to install the server (as well as other requirements)

python -m pip --disable-pip-version-check install -t ./pythonFiles/lib/python --no-cache-dir --implementation py --no-deps --upgrade --no-user -r ./requirements.txt

@IanMatthewHuff
Copy link
Member

Not if I use the VSIX though, right? With the most recent insiders VSIX I get the same result.

@rchiodo
Copy link
Contributor Author

rchiodo commented Oct 8, 2020

Yeah it should work with the VSIX. Maybe something has since broke. There's no tests making sure this continues to work

@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@rchiodo
Copy link
Contributor Author

rchiodo commented Nov 16, 2020

This would be on the python team to 'fix' if it doesn't work. Or at least the work would happen in the python extension.

@rchiodo rchiodo closed this as completed Nov 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants