Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg-make] bug: incorrect number of arguments to function #43116

Open
tahmid-khan opened this issue Jan 6, 2025 · 2 comments · May be fixed by #43121
Open

[vcpkg-make] bug: incorrect number of arguments to function #43116

tahmid-khan opened this issue Jan 6, 2025 · 2 comments · May be fixed by #43121
Assignees
@LilyWangLL
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@tahmid-khan
Copy link

I’ve encountered a bug in the vcpkg-make port while creating a port for a Make-based library.

On line 174 of vcpkg_scripts.cmake, z_vcpkg_set_global_property is invoked with one argument, but it’s defined with two parameters on line 122.

This led to the following error when building my package.

CMake Error at installed/arm64-osx/share/vcpkg-make/vcpkg_scripts.cmake:174 (z_vcpkg_set_global_property):
  z_vcpkg_set_global_property Function invoked with incorrect arguments for
  function named: z_vcpkg_set_global_property
Call Stack (most recent call first):
  installed/arm64-osx/share/vcpkg-make/vcpkg_make.cmake:276 (vcpkg_restore_pkgconfig)
  installed/arm64-osx/share/vcpkg-make/vcpkg_make_configure.cmake:106 (vcpkg_make_run_configure)
  ports/petsc/portfile.cmake:58 (vcpkg_make_configure)
  scripts/ports.cmake:196 (include)
@JackBoosY
Copy link
Contributor

cc @Neumann-A

@dg0yt
Copy link
Contributor

dg0yt commented Jan 6, 2025 •
edited
Loading

This port was authored by @JavierMatosD.

-    set_property(GLOBAL ${ARGN} PROPERTY "z_vcpkg_global_property_${property}" ${value})
+    set_property(GLOBAL ${ARGN} PROPERTY "z_vcpkg_global_property_${property}" "${value}")

to fix passing the empty string.

@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Jan 6, 2025
@tahmid-khan tahmid-khan changed the title [vcpkg-make] bug: incorrect number of argumnets to function [vcpkg-make] bug: incorrect number of arguments to function Jan 6, 2025
@LilyWangLL LilyWangLL linked a pull request Jan 6, 2025 that will close this issue
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vcpkg-make] Fix the missing value LilyWangLL/vcpkg
4 participants
@dg0yt @JackBoosY @tahmid-khan @LilyWangLL