Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification after a long running command finishes #6372

Open
JohnPhamous opened this issue Jun 5, 2020 · 1 comment
Open

Notification after a long running command finishes #6372

JohnPhamous opened this issue Jun 5, 2020 · 1 comment
Labels
Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Milestone

Comments

@JohnPhamous
Copy link

JohnPhamous commented Jun 5, 2020

Description of the new feature/enhancement

It would be awesome to add an option for a notification bubble or sound after a long running command. Long running command can be configurable but a sane default could be 10 seconds.

The scenario for this would to switch users from a pull to push model. Without notifications, a user would have to constantly "pull" their terminal to see if their command is done. Switching to push removes the cognitive overhead of having to constantly pull and instead be pushed only once the command is done running.

Current workarounds

  • Run a script that creates a notification after the command is done: long_command; notification.py

Extra asks

Beyond allowing for notifications, it would also be helpful if users were provided a hook. Here are some scenarios the hook can cover:

  • Hitting an API to report the run length of the command (Useful for engineering systems)
  • Changing the color of your smart LEDs (Think of all the things Makers could do!)
  • Context aware notifications (If the script name contains 'foo' then do then, otherwise do that

Other Terminal support

Proposed technical implementation details (optional)

@JohnPhamous JohnPhamous added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 5, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 5, 2020
@zadjii-msft zadjii-msft added Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 9, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 9, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Jun 9, 2020
@zadjii-msft
Copy link
Member

To try and tease this apart a bit:

  • Send Desktop Notification via VT Sequence (OSC777) #7718 is tracking the ability to send a notification from a commandline script. That's something that could easily be leveraged by notify.py (or whatever) to send a notification when the build finishes.
  • "Alert on next mark" is a really great idea. I think I want this thread to track that feature now.
  • terminal activity indicator/alert when in background #7955 is also tracking kinda the inverse of this thread.
    • This thread is "I want a notification after some time, when a command finishes"
    • That thread is "I want a notification if there's any output in an inactive tab"

I might want to spend a hot minute syncing these two designs with each other - we definitely don't want to send a notification for BOTH "there was new output" and "that output was the next mark". I suppose if both settings are enabled, we can defer to "there was output".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

2 participants