Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a switch to disable closing a tab if it is not active #13062

Closed
trajano opened this issue May 9, 2022 · 3 comments
Closed

Add a switch to disable closing a tab if it is not active #13062

trajano opened this issue May 9, 2022 · 3 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@trajano
Copy link

trajano commented May 9, 2022

Description of the new feature/enhancement

Sometimes when switching tabs, I accidentally hit the close button when I am expecting to switch tabs. I am asking if we can add a switch that is disabled by default to disable closing the tab if is it not presently active, as such if I want to close an inactive tab I have to press the close button twice.

Proposed technical implementation details (optional)

Assuming the setting is present. It's a matter of

on close tab
  if not active
    return or just set tab to foreground
  else 
   close the tab
  endif
@trajano trajano added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 9, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 9, 2022
@zadjii-msft
Copy link
Member

Huh. This seems like a variation on #3335. In addition to the proposed

"tab.showCloseButton": "always"|"hover"|"never"

maybe something like "tab.showCloseButton": "active" to make it only visible when the tab is the active tab? That has the added complication though - is there a activeAndHover version? inactiveAndHover? activeNoHover? That might be too complicated.

Maybe the better solution is just some version of the warnings proposed in #6549 (comment). Does that seem like a viable solution to this workflow/?

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 16, 2022
@trajano
Copy link
Author

trajano commented May 16, 2022

I think we can merge this into one user story that collects all of the scenarios and lists it out like #6549 (comment)

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels May 16, 2022
@trajano
Copy link
Author

trajano commented May 16, 2022

merge with #3335 and #6549 please

@trajano trajano closed this as completed May 16, 2022
@zadjii-msft zadjii-msft added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label May 16, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 16, 2022
@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants