Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is rn-fetch-blob supported by RNW ? (Confusing documentation) #7970

Closed
thedf opened this issue Jun 8, 2021 · 11 comments
Closed

Is rn-fetch-blob supported by RNW ? (Confusing documentation) #7970

thedf opened this issue Jun 8, 2021 · 11 comments
Labels

Comments

@thedf
Copy link

thedf commented Jun 8, 2021

Hey there,

I want to know if the library rn-fetch-blob is yet supported by RNW, because in the Community modules section in the docs it says that this library is already supported but I couldn't find the implementation.

Thanks in advance.

@thedf thedf added the question label Jun 8, 2021
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jun 8, 2021
@asklar
Copy link
Member

asklar commented Jun 8, 2021

hey @thedf - there is a PR to add Windows support, but the repo owner abandoned the repo. @RonRadtke has forked the repo and integrated the Windows support PR, here: https://github.com/RonRadtke/react-native-blob-util

@thedf
Copy link
Author

thedf commented Jun 8, 2021

Thanks alot @asklar !

@thedf thedf closed this as completed Jun 8, 2021
@ghost ghost removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jun 8, 2021
@thedf
Copy link
Author

thedf commented Jun 8, 2021

Error
I am getting these errors when using both the code from the PR or the code from the repo you mentioned. Do you happen to know the source of these errors or how to fix them?

@ghost ghost added the Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) label Jun 8, 2021
@asklar
Copy link
Member

asklar commented Jun 8, 2021

looks like the error screenshot didn't work, can you paste the error text?

@thedf
Copy link
Author

thedf commented Jun 8, 2021

Image

Severity	Code	Description	Project	File	Line	Suppression State
Error	C2065	'currentDllHanlde': undeclared identifier	RNFetchBlob	E:\PROJECT\node_modules\react-native-windows\Microsoft.ReactNative.Cxx\JSI\JsiApiContext.cpp	34	
Error	C2065	'currentDllHanlde': undeclared identifier	RNFetchBlob	E:\PROJECT\node_modules\react-native-windows\Microsoft.ReactNative.Cxx\JSI\JsiApiContext.cpp	35	
Error	C2065	'HMODULE': undeclared identifier	RNFetchBlob	E:\PROJECT\node_modules\react-native-windows\Microsoft.ReactNative.Cxx\JSI\JsiApiContext.cpp	34	
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	RNFetchBlob	E:\PROJECT\node_modules\react-native-windows\Microsoft.ReactNative.Cxx\JSI\JsiApiContext.cpp	9	
Error		PRI175: 0x80070002 - Processing Resources failed with error: The system cannot find the file specified.	PROJECT E:\PROJECT\windows\bymegallery\GENERATEPROJECTPRIFILE	1	
Error		PRI252: 0xdef00071 - File E:\PROJECT\windows\Debug\RNFetchBlob\RNFetchBlob.pri not found.	PROJECT	E:\PROJECT\windows\PROJECT\GENERATEPROJECTPRIFILE	1	
Error	C2061	syntax error: identifier 'HMODULE'	RNFetchBlob	E:\PROJECT\node_modules\react-native-windows\Microsoft.ReactNative.Cxx\JSI\JsiApiContext.cpp	34	
Error	C2146	syntax error: missing ';' before identifier 'currentDllHanlde'	RNFetchBlob	E:\PROJECT\node_modules\react-native-windows\Microsoft.ReactNative.Cxx\JSI\JsiApiContext.cpp	34	
Error	C2146	syntax error: missing ';' before identifier '__ImageBase'	RNFetchBlob	E:\PROJECT\node_modules\react-native-windows\Microsoft.ReactNative.Cxx\JSI\JsiApiContext.cpp	9	

There seems to be a problem with my internet and github. here is the text version

@asklar
Copy link
Member

asklar commented Jun 8, 2021

please add a #include <windows.h> to your app's pch.h

@thedf
Copy link
Author

thedf commented Jun 8, 2021

I do have it already
2

@asklar
Copy link
Member

asklar commented Jun 8, 2021

make sure the module's pch.h has it too

@thedf
Copy link
Author

thedf commented Jun 8, 2021

including the library in pch.h of the module fixes the problem. Thanks a lot !
It should probably be added to the original repo and PR so it won't happen to other people.

@asklar
Copy link
Member

asklar commented Jun 8, 2021

filed RonRadtke/react-native-blob-util#43

@thedf
Copy link
Author

thedf commented Jun 8, 2021

You are amazing @asklar !

@chrisglein chrisglein removed the Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) label Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants