vsls-reqs doesn't fail if it can't install libssl1.1

[ermshiperete]

Describe what happened:

Ubuntu 22.04 doesn't provide a libssl1.1 package which vsls requires. The vsls-reqs script tries to install that package and outputs a message E: Package 'libssl1.1' has no installation candidate. However, this doesn't stop the script from continuing and ending with (*) Success! and returning 0 as exit code. This makes it harder to detect that there is a dependency problem.

What was your system configuration?
Product and Version [VS/VSCode]: VSCode 1.70.2
OS Version[macOS/Windows]: Ubuntu 22.04
Live Share Extension Version: v1.0.5690

Steps to Reproduce / Scenario:

1. On a Ubuntu 22.04 machine make sure that you don't have libssl1.1 installed (sudo apt remove libssl1.1)
2. Run wget -O ~/vsls-reqs https://aka.ms/vsls-linux-prereq-script && chmod +x ~/vsls-reqs
3. Run ~/vsls-reqs
4. Notice how it ends in (*) Success!, but libssl1.1 is still not installed.

Please attach logs to this issue:

The output of running vsls-reqs:

Visual Studio Live Share Linux Dependency Installer

See https://aka.ms/vsls-docs/linux-prerequisites

Visual Studio Live Share requires a number of prerequisites that this script
will attempt to install for you. This process requires admin / root access.

To begin the installation process, your OS will now ask you to enter your
admin / root (sudo) password.


(*) Detected Debian / Ubuntu

(*) Updating package lists...
Hit:1 https://cli.github.com/packages stable InRelease
Hit:2 https://download.mono-project.com/repo/ubuntu stable-focal InRelease
Ign:3 http://linux.dropbox.com/ubuntu disco InRelease
Hit:4 https://download.virtualbox.org/virtualbox/debian jammy InRelease
Hit:5 http://linux.dropbox.com/ubuntu disco Release
Hit:6 http://de.archive.ubuntu.com/ubuntu jammy InRelease
Hit:7 https://brave-browser-apt-release.s3.brave.com stable InRelease
Hit:8 https://dl.google.com/linux/chrome/deb stable InRelease
Hit:9 http://de.archive.ubuntu.com/ubuntu jammy-updates InRelease
Hit:10 https://packages.microsoft.com/repos/vscode stable InRelease
Hit:11 https://ppa.launchpadcontent.net/alessandro-strada/ppa/ubuntu jammy InRelease
Get:12 http://de.archive.ubuntu.com/ubuntu jammy-backports InRelease [99,8 kB]
Hit:13 https://packages.microsoft.com/ubuntu/22.04/prod jammy InRelease
Get:14 http://security.ubuntu.com/ubuntu jammy-security InRelease [110 kB]
Hit:15 https://packages.microsoft.com/repos/code stable InRelease
Hit:16 https://ppa.launchpadcontent.net/ermshiperete/digitale-briefwahl/ubuntu jammy InRelease
Hit:17 https://ppa.launchpadcontent.net/git-core/ppa/ubuntu jammy InRelease
Ign:18 https://artifacts.crowdin.com/repo/deb  InRelease
Hit:19 https://artifacts.crowdin.com/repo/deb  Release
Hit:20 https://ppa.launchpadcontent.net/keymanapp/keyman/ubuntu jammy InRelease
Hit:21 https://ppa.launchpadcontent.net/mozillateam/ppa/ubuntu jammy InRelease
Fetched 210 kB in 4s (51,6 kB/s)
Reading package lists...

(*) Verifying .NET Core dependencies...
Reading package lists...
Building dependency tree...
Reading state information...
libicu70 is already the newest version (70.1-2).
libkrb5-3 is already the newest version (1.19.2-2).
zlib1g is already the newest version (1:1.2.11.dfsg-2ubuntu9).
0 upgraded, 0 newly installed, 0 to remove and 1 not upgraded.
(*) openssl already installed.
Reading package lists...
Building dependency tree...
Reading state information...
Package libssl1.1 is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'libssl1.1' has no installation candidate

(*) Verifying keyring dependencies...
Reading package lists...
Building dependency tree...
Reading state information...
libsecret-1-0 is already the newest version (0.20.5-2).
gnome-keyring is already the newest version (40.0-3ubuntu3).
0 upgraded, 0 newly installed, 0 to remove and 1 not upgraded.

(*) Verifying browser integration dependencies...
Reading package lists...
Building dependency tree...
Reading state information...
desktop-file-utils is already the newest version (0.26-1ubuntu3).
x11-utils is already the newest version (7.7+5build2).
0 upgraded, 0 newly installed, 0 to remove and 1 not upgraded.

(*) Success!

[ermshiperete]

IMO the best solution would be if vsls-reqs would call set -e at the beginning... Then it would stop when it can't install libssl1.1 and exit with a non-0 value.

[ermshiperete]

See #4646 where the current behavior causes problems...